Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix-synapse-unwrapped: 1.107.0 -> 1.108.0 #315469

Merged
merged 1 commit into from
May 29, 2024
Merged

matrix-synapse-unwrapped: 1.107.0 -> 1.108.0 #315469

merged 1 commit into from
May 29, 2024

Conversation

Guanran928
Copy link
Contributor

@Guanran928 Guanran928 commented May 28, 2024 •
edited
Loading

Diff: element-hq/synapse@v1.107.0...v1.108.0

Changelog: https://github.com/element-hq/synapse/releases/tag/v1.108.0

Description of changes

Not tested on real server, nixosTests passes.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

NickCao
NickCao approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream diff LGTM, tested on my HS.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3999

@NickCao NickCao merged commit cccf19a into NixOS:master May 29, 2024
32 checks passed
@github-actions github-actions bot mentioned this pull request May 29, 2024
Merged
1 task
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-23.11:

@github-actions GitHub Actions
Copy link
Contributor

Git push to origin failed for release-23.11 with exitcode 1

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Git push to origin failed for release-23.11 with exitcode 1

@github-actions GitHub Actions
Copy link
Contributor

Git push to origin failed for release-24.05 with exitcode 1

@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.05:

@github-actions github-actions bot mentioned this pull request May 29, 2024
Merged
1 task
@github-actions GitHub Actions
Copy link
Contributor

Git push to origin failed for release-24.05 with exitcode 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickCao NickCao NickCao approved these changes

@sumnerevans sumnerevans Awaiting requested review from sumnerevans

@Ma27 Ma27 Awaiting requested review from Ma27

@dali99 dali99 Awaiting requested review from dali99

@mguentner mguentner Awaiting requested review from mguentner

@Ralith Ralith Awaiting requested review from Ralith

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 12.approved-by: package-maintainer backport release-24.05 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Guanran928 @nixos-discourse @NickCao @wegank