Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

aw-awatcher: init at 0.2.7 #315864

Closed
wants to merge 1 commit into from
Closed

Conversation

BhasherBEL
Copy link
Contributor

Description of changes

https://github.com/2e3s/awatcher

Activity and idle watchers for activitywatch compatible with wayland and hyprland.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4066

pkgs/by-name/aw/aw-awatcher/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/aw/aw-awatcher/Cargo.lock Outdated Show resolved Hide resolved
@BhasherBEL BhasherBEL force-pushed the aw-awatcher branch 3 times, most recently from a55155f to e52c007 Compare June 10, 2024 17:05
Copy link
Member

@0x61nas 0x61nas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me, thanks

license = lib.licenses.mpl20;
maintainers = with lib.maintainers; [ bhasher ];
mainProgram = "awatcher";
platforms = lib.platforms.linux;
Copy link
Member

@0x61nas 0x61nas Jun 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

am not sure if we need to mark it as broken on darwin if we already exclude it here. but specifying linux as the only supported platform, should be enough

@sifmelcara
Copy link
Member

This is duplicate of #287858 (which is stalled), also here is a reference to the packaging request: #287826

@aikooo7 are you still interested in merging the PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be in a separate commit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can split it if it's necessary

@aikooo7
Copy link
Contributor

aikooo7 commented Jun 11, 2024

This is duplicate of #287858 (which is stalled), also here is a reference to the packaging request: #287826

@aikooo7 are you still interested in merging the PR?

My bad for being so much time out first of all.

I had indeed some stuff to do in that pr that I didn't see, my bad. Everything should be fixed now and now I am also using the latest version.

@BhasherBEL
Copy link
Contributor Author

BhasherBEL commented Jun 12, 2024

Feel free to merge the other PR, but it seems stale and was several versions behind. It also include the Cargo.lock, by the opposite to here.

@aikooo7
Copy link
Contributor

aikooo7 commented Jun 13, 2024

Feel free to merge the other PR, but it seems stale and was several versions behind. It also include the Cargo.lock, by the opposite to here.

  1. Thanks for callout, I did destroy the commit that I had changed to use the latest version and didn't notice it, it should be the latest version now.
  2. You pull the Cargo.lock at build time, I pre-pulled it, both might exist and I am using what I saw in the rust's nixos documentation, what is the issue?

@BhasherBEL
Copy link
Contributor Author

1. Thanks for callout, I did destroy the commit that I had changed to use the latest version and didn't notice it, it should be the latest version now.

Yup, it's perfect now, my comment was anterior to that change.

2. You pull the Cargo.lock at build time, I pre-pulled it, both might exist and I am using what I saw in the rust's nixos documentation, what is the issue?

I can agree with you and did that at first, but I changed due to a comment.

To be honest I don't really care which PR is merged, but I would love to see this package in nixpkgs, so if it's faster with your PR, I'm in.

@BhasherBEL
Copy link
Contributor Author

Closed in favor of #287858, which is now more up to date.

@BhasherBEL BhasherBEL closed this Jun 21, 2024
@Guekka Guekka mentioned this pull request Jun 25, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants