-
-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport release-24.05] virtualbox & virtualboxGuestAdditions: cleanup #316400
Conversation
(cherry picked from commit 5875b59)
(cherry picked from commit 0507f64)
(cherry picked from commit 4b3ae36)
(cherry picked from commit b9d92af)
(cherry picked from commit f9966d5)
(cherry picked from commit 64512b6)
(cherry picked from commit 52b8494)
(cherry picked from commit 0d8d623)
(cherry picked from commit 0aaed92)
(cherry picked from commit b9b8904)
(cherry picked from commit 81f4b1d)
(cherry picked from commit fae0e70)
(cherry picked from commit b9ed0a3)
(cherry picked from commit 296a513)
(cherry picked from commit 9496bd2)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't really fit the back porting guidelines, but given that it will make it easier to support the release by making future back ports easier I think it's still worthwhile.
I do think that we shouldn't change the option name though.
@@ -52,7 +52,7 @@ in | |||
description = "Whether to enable seamless mode. When activated windows from the guest appear next to the windows of the host."; | |||
}; | |||
|
|||
draganddrop = mkOption { | |||
dragAndDrop = mkOption { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't break people's configs in the release branch. What are your thoughts here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the mkRenamedOption was missed here which wouldn't make this a problem
Made a manual backport PR: #318311 |
Bot-based backport to
release-24.05
, triggered by a label in #303790.