Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-24.05] virtualbox & virtualboxGuestAdditions: cleanup #316400

Closed
wants to merge 15 commits into from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 1, 2024

Bot-based backport to release-24.05, triggered by a label in #303790.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

Copy link
Contributor

@blitz blitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't really fit the back porting guidelines, but given that it will make it easier to support the release by making future back ports easier I think it's still worthwhile.

I do think that we shouldn't change the option name though.

@@ -52,7 +52,7 @@ in
description = "Whether to enable seamless mode. When activated windows from the guest appear next to the windows of the host.";
};

draganddrop = mkOption {
dragAndDrop = mkOption {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't break people's configs in the release branch. What are your thoughts here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the mkRenamedOption was missed here which wouldn't make this a problem

@lelgenio
Copy link

lelgenio commented Jun 8, 2024

Made a manual backport PR: #318311

@lelgenio lelgenio closed this Jun 8, 2024
@SuperSandro2000 SuperSandro2000 deleted the backport-303790-to-release-24.05 branch June 12, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants