[Backport release-24.05] virtualbox & virtualboxGuestAdditions: cleanup #318311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested by cherry picking #311362 |
This was referenced Jun 8, 2024
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4097 |
blitz
reviewed
Jun 17, 2024
lelgenio
force-pushed
the
backport-cleanup-virtualbox
branch
from
9105f37
to
a703430
Compare
blitz
approved these changes
Jun 20, 2024
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1789 |
presto8
pushed a commit
to presto8/nixpkgs
that referenced
this pull request
Jul 11, 2024
…up (NixOS#318311) * virtualbox: remove with lib * virtualboxGuestAdditions: remove with lib * virtualboxGuestAdditions: move more buildInputs to nativeBuildInputs * virtualbox: introduce finalAttrs * virtualbox: remove old patch * virtualboxGuestAdditions: Add dragAndDrop service * fixup! virtualboxGuestAdditions: Add dragAndDrop service * virtualbox: disable VBOX_WITH_UPDATE_AGENT * virtualboxGuestAdditions: disable VBOX_WITH_UPDATE_AGENT * virtualboxGuestAdditions: disable more includes * virtualboxGuestAdditions: ignore more includes when building * virtualboxGuestAdditions: cleanup * virtualboxGuestAdditions: remove alsa & pulse deps * virtualboxGuestAdditions: remove makeWrapper dep * virtualboxGuestAdditions: use nix packaged lzma * virtualbox: remove nasm * Update nixos/modules/virtualisation/virtualbox-guest.nix --------- Co-authored-by: Friedrich Altheide <11352905+FriedrichAltheide@users.noreply.github.com> Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Needed for #318330 which fixes #312336
Backported PRs: #303790 + #317756
Replaces: #316400
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.