Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wxmaxima: 15.04.0 -> 17.10.1 #31657

Merged
merged 1 commit into from Nov 14, 2017
Merged

wxmaxima: 15.04.0 -> 17.10.1 #31657

merged 1 commit into from Nov 14, 2017

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Nov 14, 2017 •
edited

Motivation for this change

also fix crash at start-up due missing icons

fixes #18479

As the current version is also broken on 17.09, I would backport it.

cc @8573

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
wxmaxima: 15.04.0 -> 17.10.1
2142352 
also fix crash at start-up due missing icons

fixes NixOS#18479
@Mic92 Mic92 requested a review from peti November 14, 2017 11:29
@peti peti merged commit 12c922d into NixOS:master Nov 14, 2017
@Mic92 Mic92 deleted the wxmaxima branch November 14, 2017 13:50
@Mic92 Mic92 added the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 15, 2017
@Mic92
Copy link
Member Author

Mic92 commented Nov 15, 2017

Should I backport this?

@peti
Copy link
Member

peti commented Nov 15, 2017

I pushed a5f90be and b3b1f2e to release-17.09.

@8573
Copy link
Contributor

8573 commented Dec 29, 2017

Strangely, after updating to latest nixos-unstable, which, by Git history, seems to include this patch, I get

$ wxmaxima --version
wxMaxima 16.12.x-unofficial

@8573 8573 mentioned this pull request Dec 29, 2017
Closed
@orivej
Copy link
Contributor

orivej commented Dec 29, 2017

@8573 See http://howoldis.herokuapp.com/

@8573
Copy link
Contributor

8573 commented Dec 29, 2017

@orivej: I suppose you mean to suggest that I should conclude from the information on howoldis that I don't actually have the patch. If so, from what detail on that page should I conclude that? The salient datum seems to me to be the Git commit hash listed for nixos-unstable, which I took into account in my previous comment.

@orivej
Copy link
Contributor

orivej commented Dec 29, 2017

@8573 Ah, sorry. This is how it reports its version when it is built with autotools; we should switch to cmake.

@8573
Copy link
Contributor

8573 commented Dec 29, 2017

Ah! Okay, thanks for the information.

@orivej
Copy link
Contributor

orivej commented Dec 29, 2017

Switched to cmake in 77cc639.

vdemeester pushed a commit to vdemeester/nixpkgs that referenced this pull request Dec 29, 2017
@orivej
wxmaxima: build with cmake
77cc639 
Fixes reported version number: see
NixOS#31657 (comment)

"make check" did not run any tests with autotools, and is not defined with
cmake. ("make test" is not defined too.)
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wxmaxima missing hicolor icon theme?
6 participants
@Mic92 @peti @8573 @orivej @samueldr @GrahamcOfBorg