grub2: make localization resources deterministic #316655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raboof
added
6.topic: reproducible builds
backport release-24.05
by taking them from the release tarball instead of from the (nondeterministic) translation portal. See also NixOS#245356 Fixes NixOS#263095
raboof
force-pushed
the
grub2-deterministic-locales
branch
from
b6b7631
to
db2b9eb
Compare
drupol
approved these changes
Jun 2, 2024
|
Maybe we should just build the whole thing from the tarball then? I was going to do that for the release, but then I completely forgot :( |
I personally like building from VCS source, makes it much easier to apply patches etc.. A bit more far-fetched, it might also leave fewer opportunities for an attacker to hide anything in generated artifacts (like the configure script, I suppose?) |
|
Successfully created backport PR for |
1 task
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
by taking them from the release tarball instead of from the (nondeterministic) translation portal.
See also #245356
Fixes #263095
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.