Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtualbox guest module: draganddrop became dragAndDrop #317756

Merged

Conversation

raboof
Copy link
Member

@raboof raboof commented Jun 6, 2024

Description of changes

the draganddrop option to the virtualbox.guest module was renamed in 61c1d28. This adds a mkRenamedOptionModule to make the migration more user-friendly.

follow-up on #303790

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

the `draganddrop` option to the `virtualbox.guest` module was
renamed in 61c1d28. This adds a `mkRenamedOptionModule` to make
the migration more user-friendly.
@SuperSandro2000 SuperSandro2000 merged commit 2389f5f into NixOS:master Jun 6, 2024
7 of 8 checks passed
Uthar pushed a commit to Uthar/nixpkgs that referenced this pull request Jun 28, 2024
…7756)

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants