Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minikube: Add vmnet as buildInput on darwin #31830

Closed
wants to merge 1 commit into from
Closed

minikube: Add vmnet as buildInput on darwin #31830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkgs/applications/networking/cluster/minikube/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{ stdenv, buildGoPackage, fetchFromGitHub, fetchurl, go-bindata, kubernetes, libvirt, qemu, docker-machine-kvm,
vmnet,
gpgme, makeWrapper }:

let
Expand Down Expand Up @@ -36,7 +37,8 @@ in buildGoPackage rec {

# kubernetes is here only to shut up a loud warning when generating the completions below. minikube checks very eagerly
# that kubectl is on the $PATH, even if it doesn't use it at all to generate the completions
buildInputs = [ go-bindata makeWrapper kubernetes gpgme ];
buildInputs = [ go-bindata makeWrapper kubernetes gpgme ]
++ stdenv.lib.optionals stdenv.isDarwin [ vmnet ];
subPackages = [ "cmd/minikube" ];

preBuild = ''
Expand Down
4 changes: 3 additions & 1 deletion pkgs/top-level/all-packages.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15661,7 +15661,9 @@ with pkgs;

minidjvu = callPackage ../applications/graphics/minidjvu { };

minikube = callPackage ../applications/networking/cluster/minikube { };
minikube = callPackage ../applications/networking/cluster/minikube {
inherit (darwin.apple_sdk.frameworks) vmnet;
};

minitube = callPackage ../applications/video/minitube { };

Expand Down