Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHC 8.2.2 in 17.09 #32002

Merged
merged 3 commits into from Dec 6, 2017
Merged

GHC 8.2.2 in 17.09 #32002

merged 3 commits into from Dec 6, 2017

Conversation

vaibhavsagar
Copy link
Member

@vaibhavsagar vaibhavsagar commented Nov 24, 2017 •
edited

Motivation for this change

I want GHC 8.2.2 in release-17.09. To achieve this, I ran

git cherry-pick -x --strategy-option=theirs --no-merges --first-parent `git log --reverse --format=format:%H ..origin/master -- pkgs/development/compilers/ghc/8.2.2.nix`
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

peti and others added 3 commits November 24, 2017 21:36
@peti @vaibhavsagar
ghc: add 8.2.2-rc2
bb3a429 
(cherry picked from commit a09460b)
@peti @vaibhavsagar
ghc: bump 8.2.2 pre-release to rc3
0af1411 
(cherry picked from commit e876aa4)
@vaibhavsagar
ghc: 8.2.2-rc2 -> 8.2.2
a6be66a 
(cherry picked from commit b1a0f91)
@vaibhavsagar
Copy link
Member Author

Any further work required from me on this?

@vcunat vcunat added 6.topic: haskell 8.has: port to stable A PR already has a backport to the stable release. labels Nov 27, 2017
@domenkozar domenkozar merged commit 0190109 into NixOS:release-17.09 Dec 6, 2017
@vaibhavsagar vaibhavsagar deleted the ghc-822-17.09 branch December 6, 2017 11:13
@vaibhavsagar
Copy link
Member Author

Thanks!

@XVilka XVilka mentioned this pull request Nov 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenkozar domenkozar domenkozar approved these changes

@Ericson2314 Ericson2314 Ericson2314 approved these changes

Assignees
No one assigned
Labels
6.topic: haskell 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vaibhavsagar @domenkozar @Ericson2314 @vcunat @GrahamcOfBorg @peti