nixos/nvidia: move TOPOLOGY_FILE_PATH and DATABASE_PATH into nvidia-fabricmanager service definition #320830
+8
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… hardware.nvidia.datacenter.settings default into the service file
philiptaron
requested review from
Kiskae,
ConnorBaker,
SomeoneSerge and
FireyFly
FireyFly
approved these changes
Jun 19, 2024
13 tasks
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1787 |
Comment on lines
-49
to
-50
| TOPOLOGY_FILE_PATH = "${nvidia_x11.fabricmanager}/share/nvidia-fabricmanager/nvidia/nvswitch"; | ||
| DATABASE_PATH = "${nvidia_x11.fabricmanager}/share/nvidia-fabricmanager/nvidia/nvswitch"; |
There was a problem hiding this comment.
Side-note: I find these passthru packages in nvidia_x11 rather annoying; we recently found that e.g. libXNctrl could be moved out of nvidia_x11 entirely (#318092); do you know if is fabricmanager driver-locked?
There was a problem hiding this comment.
https://docs.nvidia.com/datacenter/tesla/pdf/fabric-manager-user-guide.pdf
That diagram suggests that it is, sadly, but I don't know for sure.
| # unsuitable to be mentioned in the configuration defaults, but they _can_ | ||
| # be overridden in `cfg.datacenter.settings` if needed. | ||
| fabricManagerConfDefaults = { | ||
| TOPOLOGY_FILE_PATH = "${nvidia_x11.fabricmanager}/share/nvidia-fabricmanager/nvidia/nvswitch"; |
There was a problem hiding this comment.
Sanity-check: here nvidia_x11 != null because it's guarded by cfg.enable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Move the TOPOLOGY_FILE_PATH and DATABASE_PATH keys from
hardware.nvidia.datacenter.settingsdefault into the service file derivation. As can be seen on line 9,nvidia_x11can be null and thus is unsuitable for use in this venue.I discovered this while testing out #313497.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)