-
-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use libXNVCtrl purely #318092
Use libXNVCtrl purely #318092
Conversation
Put the path to libXNVCtrl on the RPATH of the MangoHUD binary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aidalgol! The change looks good to me - but I don't have an nvidia device to test this on right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, it's an X extension with embedded version support, the client should check that the corresponding server has the support it requires.
Description of changes
libXNVCtrl
is not tied to the Nvidia driver version, so we don't need to apply it via the NixOS optionhardware.opengl.extraPackages
, and can instead let consumers of the library use it via the derivation directly.Closes #314289.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.