*bsdCross: Remove these package sets #321538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
This is the most upstream one, and so to avoid infinite recursion we should get the things from it. This isn't needed per-se now, but will be after the next commit. (cherry picked from commit 4bd76be)
I realized what rhelmot did in 6120256 (specify what packages just need `stdenvNoLibc`) is definitely the right approach for this, and adjusted NetBSD and OpenBSD to likewise use it. With that change, we don't need these confusing and ugly `*bsdCross` package sets at all! We can get rid of a lot more libc-related `*Cross`, and I will do so soon, but this is the first step. (adapted from commit 51f1eca)
Ericson2314
force-pushed
the
no-bsdCross-pkg-set
branch
from
76695f1
to
744d7e7
Compare
|
No more stdenv rebuild, and for what it's worth, most of the darwin changes are actually things that are marked unsupported on darwin. |
|
Successfully created backport PR for |
1 task
|
Git push to origin failed for release-24.05 with exitcode 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
I realized what @rhelmot did in 6120256 (specify what packages just need
stdenvNoLibc) is definitely the right approach for this, and adjusted NetBSD and OpenBSD to likewise use it. With that change, we don't need these confusing and ugly*bsdCrosspackage sets at all!We can get rid of a lot more libc-related
*Cross, and I will do so soon, but this is the first step.(adapted from commit 51f1eca)
Part of take 2 of #320852, without the infra changes. This, unlike the other, is safer to backport.
(They are still kept as deprecated aliases.)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.