Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weechat: default to enabling all plugins #32174

Merged
merged 1 commit into from Nov 29, 2017

Conversation

lheckemann
Copy link
Member

Motivation for this change

Since a few people have been confused by the absence of python support in the weechat attribute in nixpkgs, provide all plugins by default. Comments on the interface or the principle welcome!

Plain weechat is still accessible as weechat.unwrapped or weechat.override {configure = null;}.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Plain weechat is still accessible as `weechat.unwrapped`
or `weechat.override {configure = null;}`.

Also update documentation to reflect this change.
@lheckemann
Copy link
Member Author

@GrahamcOfBorg build weechat

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 51000  100 51000    0     0  51000      0  0:00:01 --:--:--  0:00:01  327k


  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 57992  100 57992    0     0  57992      0  0:00:01 --:--:--  0:00:01  351k

building path(s) ‘/nix/store/k13gdf5jqm7v85hd9xx6954wqm10z8bb-weechat-plugins’
building path(s) ‘/nix/store/y8448lxgmyb8wz09m006wzb2r73vh793-weechat’
/nix/store/y8448lxgmyb8wz09m006wzb2r73vh793-weechat

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

  /nix/store/mkx5m7c7gqq72rysr72m2wbzwivn3gzr-weechat-1.9.1-lua
  /nix/store/mmfmwl9l1jwqn7jipq1w4bvb66map61s-weechat-1.9.1-perl
copying path '/nix/store/bzgpzdahyd1vy4qk8was151ak2q488nd-weechat-1.9.1' from 'https://cache.nixos.org'...
copying path '/nix/store/85z4gz545cr64fvd35f9iyq2m3zsynys-weechat-1.9.1-guile' from 'https://cache.nixos.org'...
copying path '/nix/store/mkx5m7c7gqq72rysr72m2wbzwivn3gzr-weechat-1.9.1-lua' from 'https://cache.nixos.org'...
copying path '/nix/store/mmfmwl9l1jwqn7jipq1w4bvb66map61s-weechat-1.9.1-perl' from 'https://cache.nixos.org'...
copying path '/nix/store/2lflmxb5639wrd6833r7gj09vpds2zpk-weechat-1.9.1-python' from 'https://cache.nixos.org'...
copying path '/nix/store/bjgri29a142ln7dh4fribixqmirw2w7c-weechat-1.9.1-ruby' from 'https://cache.nixos.org'...
copying path '/nix/store/caw2hnkawb0f9hcfpfkmda0s2akpq7lk-weechat-1.9.1-tcl' from 'https://cache.nixos.org'...
error: a 'x86_64-darwin' is required to build '/nix/store/3wgs4dk1jfv27a497i7kkdyqk8abb0r5-weechat-plugins.drv', but I am a 'x86_64-linux'

@Mic92
Copy link
Member

Mic92 commented Nov 29, 2017

@GrahamcOfBorg build weechat

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-darwin

copying path '/nix/store/85z4gz545cr64fvd35f9iyq2m3zsynys-weechat-1.9.1-guile' to 'ssh://mac1'...
copying 1 paths...
copying path '/nix/store/cf933005qcs0713bj7f3i8xdb1dcbw1h-weechat-plugins' from 'ssh://mac1'...
building '/nix/store/94m77sy714xh7ad7m7v37l3i65p40b9b-weechat.drv' on 'ssh://mac1'...
copying 2 paths...
copying path '/nix/store/0za65fx5jqw1h48d3n7z82500gvnf9rq-aspell-0.60.6.1' to 'ssh://mac1'...
copying path '/nix/store/bzgpzdahyd1vy4qk8was151ak2q488nd-weechat-1.9.1' to 'ssh://mac1'...
copying 1 paths...
copying path '/nix/store/pwma500hlp4i4dnp03xk5ivqzf57cf75-weechat' from 'ssh://mac1'...
/nix/store/pwma500hlp4i4dnp03xk5ivqzf57cf75-weechat

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux



*** Downloading ‘https://cache.nixos.org/nar/1r1qwfn9wa7j31gj21rjxlcv1xv6p7hhmc509pcw7367x5r77pac.nar.xz’ (signed by ‘cache.nixos.org-1’) to ‘/nix/store/7faq0r8kmws5bvjnkc3ffgkyr1zvz4i1-weechat-1.9.1-ruby’...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 51000  100 51000    0     0  51000      0  0:00:01 --:--:--  0:00:01  309k

building path(s) ‘/nix/store/k13gdf5jqm7v85hd9xx6954wqm10z8bb-weechat-plugins’
building path(s) ‘/nix/store/y8448lxgmyb8wz09m006wzb2r73vh793-weechat’
/nix/store/y8448lxgmyb8wz09m006wzb2r73vh793-weechat

@Mic92 Mic92 merged commit 4657fc8 into NixOS:master Nov 29, 2017
@lheckemann lheckemann deleted the weechat-all-default branch November 29, 2017 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants