-
-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ghdl-gcc: init at 4.1.0 #322259
ghdl-gcc: init at 4.1.0 #322259
Conversation
Does the CI |
|
Yes; Yes |
eef9543
to
aa36e7e
Compare
@Aleksanaa Fixed. CI seems good now. Is there anything I can do to help this getting merged? |
Gentle ping @Lucus16 @thoughtpolice |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This mostly looks good, but I think it's important that users do not need to set LIBRARY_PATH
manually.
bc27c80
to
e94e1db
Compare
Not truly a new package, but rather a new backend next to the existing `mcode` and `llvm` ones. Adding the GCC backend too, as it is the only one that supports code coverage report generation. For more info see: https://devsaurus.github.io/ghdl_gcov/ghdl_gcov.html. Co-authored-by: Rowan Goemans <goemansrowan@gmail.com>
e94e1db
to
8dbbabe
Compare
@Lucus16 All done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Not truly a new package, but rather a new backend next to the existing
mcode
andllvm
ones. Adding the GCC backend too, as it is the only one that supports code coverage report generation. For more info see: https://devsaurus.github.io/ghdl_gcov/ghdl_gcov.html.Description of changes
Add
ghdl-gcc
, GHDL with GCC as a backend.Things done
nix-build -A ghdl-mcode.passthru.tests
nix-build -A ghdl-llvm.passthru.tests
nix-build -A ghdl-gcc.passthru.tests
nix-shell --pure
in combination withlcov
.For non-Linux: Is sandboxing enabled innix.conf
? (See Nix manual)Tested compilation of all packages that depend on this change usingnix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)(Package updates) Added a release notes entry if the change is major or breaking(Module updates) Added a release notes entry if the change is significant(Module addition) Added a release notes entry if adding a new NixOS moduleNotes
Tags
Maintainers: @Lucus16 @thoughtpolice
Colleagues: @stdefeber @rowanG077
Comments
I'd love to backport this to 24.05.
Add a 👍 reaction to pull requests you find important.