[Backport release-24.05] Development shell with a pinned nixfmt #326630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 12, 2024
superherointj
approved these changes
Jul 12, 2024
|
As I have merged #326628, this needs a re-base for CI to run fine. |
|
@infinisil Can you rebase this PR (to attempt to solve CI)? |
This creates a new directory for all CI support files, will be populated in future commits. (cherry picked from commit 1359993)
This is needed such that in the next commit, we can re-use the same version from a shell.nix, allowing people to have a guaranteed matching nixfmt version. (cherry picked from commit b33ac05)
This uses the reusable pinned Nixpkgs from the parent commit to create a shell.nix file for an environment with a pinned nixfmt version. (cherry picked from commit a70ab58)
When some files are not formatted properly, this shows how people can fix the problem. This notably uses the shell.nix introduced in the parent commit to ensure that the nixfmt version matches what CI expects. (cherry picked from commit 53b517c)
Otherwise it prints the command to run with an empty entry: nixfmt '<stuff>' '' Thanks to https://yaml-multiline.info/ for the great help with this (cherry picked from commit d0bebb7)
(cherry picked from commit 58f98e4)
infinisil
force-pushed
the
backport-322512
branch
from
17edefc
to
ebfc5f8
Compare
superherointj
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Manual backport of #322512
Things done
Add a 👍 reaction to pull requests you find important.