Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosmic-player: init at unstable-2024-03-13 #330167

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

jh-devv
Copy link

@jh-devv jh-devv commented Jul 26, 2024

Description of changes

Media Player for the COSMIC Desktop Environment.

Please note, the project is still heavily work in progress, so expect it not being so finished and stable!

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@donovanglover donovanglover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to nixpkgs! Make sure to format your code with nixfmt-rfc-style available in shell.nix

pkgs/by-name/co/cosmic-player/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/co/cosmic-player/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/co/cosmic-player/package.nix Outdated Show resolved Hide resolved
jh-devv and others added 3 commits July 28, 2024 17:11
Co-authored-by: Donovan Glover <donovan@dglover.co>
Co-authored-by: Donovan Glover <donovan@dglover.co>
Co-authored-by: Donovan Glover <donovan@dglover.co>
@jh-devv
Copy link
Author

jh-devv commented Jul 28, 2024

Welcome to nixpkgs! Make sure to format your code with nixfmt-rfc-style available in shell.nix

Thanks and well yeah... I forgot to do that :3

pkgs/by-name/co/cosmic-player/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/co/cosmic-player/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/co/cosmic-player/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/co/cosmic-player/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/co/cosmic-player/package.nix Outdated Show resolved Hide resolved
jh-devv and others added 5 commits July 28, 2024 18:54
Co-authored-by: Aleksana <alexander.huang.y@gmail.com>
Co-authored-by: Aleksana <alexander.huang.y@gmail.com>
Co-authored-by: Aleksana <alexander.huang.y@gmail.com>
Co-authored-by: Aleksana <alexander.huang.y@gmail.com>
Copy link

@camerondugan camerondugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, just needs some formatting to pass a test

pkgs/by-name/co/cosmic-player/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/co/cosmic-player/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/co/cosmic-player/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/co/cosmic-player/package.nix Outdated Show resolved Hide resolved
jh-devv and others added 5 commits September 1, 2024 22:40
Co-authored-by: Cameron Dugan <Cameron.s.dugan@gmail.com>
Co-authored-by: Cameron Dugan <Cameron.s.dugan@gmail.com>
Co-authored-by: Cameron Dugan <Cameron.s.dugan@gmail.com>
Co-authored-by: Cameron Dugan <Cameron.s.dugan@gmail.com>
forgot to do this before :3
Copy link
Contributor

@ahoneybun ahoneybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now!

Copy link

@camerondugan camerondugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I compiled and played an mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants