haskell infra, ghc: Start to fix cross compilation without changing hashes #33358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
force-pushed
the
cross-haskell-samehash
branch
from
f460fc5
to
d634a7e
Compare
Ericson2314
added
6.topic: haskell
6.topic: cross-compilation
No hashes should be changed.
Ericson2314
force-pushed
the
cross-haskell-samehash
branch
from
d634a7e
to
e567483
Compare
Cross case purposely changed as it will be rewritten anyways. But no native hashes should be changed.
Ericson2314
force-pushed
the
cross-haskell-samehash
branch
from
e567483
to
2ae63ea
Compare
Ericson2314
force-pushed
the
cross-haskell-samehash
branch
from
2ae63ea
to
b7e10f3
Compare
GrahamcOfBorg
added
10.rebuild-darwin: 501+
10.rebuild-linux: 501+
and removed
10.rebuild-darwin: 0
10.rebuild-linux: 0
labels
Ericson2314
force-pushed
the
cross-haskell-samehash
branch
from
b7e10f3
to
bc06646
Compare
GrahamcOfBorg
added
10.rebuild-darwin: 0
10.rebuild-linux: 0
and removed
10.rebuild-darwin: 501+
10.rebuild-linux: 501+
labels
8 tasks
GrahamcOfBorg
added
10.rebuild-darwin: 1-10
10.rebuild-linux: 11-100
and removed
10.rebuild-darwin: 0
labels
8 tasks
Ericson2314
commented
Jan 3, 2018
| @@ -41,6 +41,7 @@ let | |||
| libtool = nativePlatforms; | |||
| libunistring = nativePlatforms; | |||
| windows.wxMSW = nativePlatforms; | |||
| windows.mingw_w64_pthreads = nativePlatforms; | |||
There was a problem hiding this comment.
This is a function of GitHub's lousy diff algorithm. It is not part of #33358.
Ericson2314
force-pushed
the
cross-haskell-samehash
branch
from
70d59ec
to
5e31e82
Compare
GrahamcOfBorg
added
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
and removed
10.rebuild-darwin: 1-10
10.rebuild-linux: 11-100
labels
|
Pushed 8b01cb35a17..e7fb469c690 to |
|
OK, Hydra conveniently confirmed that no hashes were changed by this PR. So, I guess, there's not much test-building to be done. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This a little bit of #26799. I want to merge it first so that a) @GrahamcOfBorg can ensure there really are no rebuilds, and b) that second PR has a more readable diff.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)