Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghc, haskell-modules: ARM cross build fixes. #33733

Merged
merged 1 commit into from Jan 11, 2018
Merged

ghc, haskell-modules: ARM cross build fixes. #33733

merged 1 commit into from Jan 11, 2018

Conversation

dhess
Copy link
Contributor

@dhess dhess commented Jan 11, 2018

As requested in #33405.

/cc @Ericson2314

Motivation for this change

Fix ARM cross builds.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dhess dhess requested a review from peti as a code owner January 11, 2018 06:15
@dhess dhess mentioned this pull request Jan 11, 2018
Merged
8 tasks
peti
peti approved these changes Jan 11, 2018
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Ericson2314
Copy link
Member

Ericson2314 commented Jan 11, 2018 •
edited

❤️ thank you!

@peti peti merged commit aecc868 into NixOS:master Jan 11, 2018
@dhess dhess deleted the arm-cross-fixes branch January 17, 2018 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti peti approved these changes

@Ericson2314 Ericson2314 Ericson2314 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dhess @Ericson2314 @peti @GrahamcOfBorg