-
-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dit: 0.4 -> 0.5 #39505
dit: 0.4 -> 0.5 #39505
Conversation
Build still fails on darwin: hishamhm/dit#23 We have to wait for upstream fix. |
adds darwin support should work on *BSD
@GrahamcOfBorg build dit |
Success on x86_64-linux (full log) Attempted: dit Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: dit Partial log (click to expand)
|
@GrahamcOfBorg build dit |
Failure on x86_64-darwin (full log) Attempted: dit Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: dit Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: dit Partial log (click to expand)
|
(triage) The merge conflict is just due to the removed unused Suggestion: revert the change trying to make this work on darwin, as this update works on linux and does bring in an update. Work for darwin port later on. |
still waiting for upstream. i think the darwin build was the only change this new version should fix. it's not on the official website... should i close this and open a new PR when upstream has fixed it? |
Hmm… Looking quickly at the history, I think there are other changes brought forth by this new version, like “Don't consider _ a word-delimiter when using multiple cursors” or “Persistent redo”. So I think linux users could benefit right now from the version bump, and once upstream answers, the darwin build will be possible to fix and get in nixpkgs? :) |
@Ekleog you are right. I limited it again to linux. The project is not very actively developed, so it makes no sense to wait any longer. Please squash when merging. (Take a look at micro for a similar, but active project) |
@GrahamcOfBorg build dit |
Motivation for this change
Update to latest version.
Also preparations for darwin support, but it currently don't build.
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)