nixos docs: Update installation partitioner instructions #39942
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating the instructions to match experience - added: ``` > g # <lineannotation>(create an empty GPT table)</lineannotation> ``` - Remove this line, because there's only one partition (so you aren't prompted for the partition number) ``` > 3 # <lineannotation>(... of the boot partition ...)</lineannotation> ``` - for GPT partitions, the bootable option is under `x` (expert mode). I updated the commands to x-A-1 for bootable.
|
I will merge & cherry-pick this onto release-18.03 unless anyone has objections. |
|
@srl295 I cannot immediately find this -- what does |
|
@abbradar This is what happens: |
Mic92
reviewed
May 10, 2018
| > x # <lineannotation>(enter expert mode)</lineannotation> | ||
| > A # <lineannotation>(make the partition bootable)</lineannotation> | ||
| > 1 # <lineannotation>(...partition one, the boot partition)</lineannotation> |
There was a problem hiding this comment.
Was partition 1 no the root partition in this example?
There was a problem hiding this comment.
good catch, this is probably my typo. I was copying from line 108 above which was the last partition mentioned. Probably should be partition 3.
samueldr
added a commit
to samueldr/nixpkgs
that referenced
this pull request
Oct 4, 2018
The tests in <nixos/tests/installer.nix> are using `parted`, so they are bound to be better tested than `fdisk`. This is brought on by a couple issues, plus reports on IRC that the `fdisk` instructions didn't work as expected. * NixOS#39354 * NixOS#46309 * NixOS#39942 * NixOS#45478 Care was taken so that the other documented steps did not need changes. In all this kerfufle, a slight re-organization of the Chapter has been made, allowing better deep linking.
grahamc
pushed a commit
that referenced
this pull request
Oct 4, 2018
The tests in <nixos/tests/installer.nix> are using `parted`, so they are bound to be better tested than `fdisk`. This is brought on by a couple issues, plus reports on IRC that the `fdisk` instructions didn't work as expected. * #39354 * #46309 * #39942 * #45478 Care was taken so that the other documented steps did not need changes. In all this kerfufle, a slight re-organization of the Chapter has been made, allowing better deep linking. (cherry picked from commit 6cfbf40)
|
Hi! Closing this issue since the partitioning instructions are now re-written for 18.09. (See #47697) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the instructions to match experience
x(expert mode). I updated the commands to x-A-1 for bootable.Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)