Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update NixOS fdisk instructions based on my flow (18.03) #45478

Closed

Conversation

KiaraGrouwstra
Copy link
Contributor

The existing installation instructions did not quite match what I ran into on a clean install (NixOS 18.03) -- this PR alters the instructions to reflect my experience.

@grahamc
Copy link
Member

grahamc commented Aug 22, 2018

I'm not sure why these are an improvement. My understanding is your clean install was overtop an existing set of partitions, and not actually to a clean disk. Am I misunderstanding?

@KiaraGrouwstra
Copy link
Contributor Author

KiaraGrouwstra commented Aug 22, 2018

Hi, thanks for asking.

It's not that I wanted to preserve partitions -- I was wiping/repartitioning my SSD as part of this install.
I can't tell what was the reason the original instructions gave me issues -- they somehow did, then I documented my steps for myself / others with similar issues (?).
I can't tell which of these only occurred for me and which could be more general. If not useful, feel free to close.

Changes included:

  • partition table type MBR -> GPT: helped me solve an error File system "/boot" is not on a GPT partition table. edit: also error warning: this GPT partition label contains no BIOS Boot Partition; embedding won't be possible
  • fdisk -> gdisk -- iirc this was needed for the partition table difference above.
  • add button presses for some missing prompts, though potentially tweaked toward gdisk.
  • boot partition size: helped me solve error NixOS fails to install #34508.
  • vfat signature warnings: ignore if applicable.

@afrepues
Copy link
Contributor

afrepues commented Sep 6, 2018

Upon start, gdisk will attempt to convert any existing from MBR or BSD disklabels into a GPT. Then using the o function you can clean out that GPT to start anew.

@KiaraGrouwstra
Copy link
Contributor Author

I'll close as it doesn't appear clear whether this would be of use.

samueldr added a commit to samueldr/nixpkgs that referenced this pull request Oct 4, 2018
The tests in <nixos/tests/installer.nix> are using `parted`, so they are
bound to be better tested than `fdisk`.

This is brought on by a couple issues, plus reports on IRC that the
`fdisk` instructions didn't work as expected.

 * NixOS#39354
 * NixOS#46309
 * NixOS#39942
 * NixOS#45478

Care was taken so that the other documented steps did not need changes.

In all this kerfufle, a slight re-organization of the Chapter has been
made, allowing better deep linking.
grahamc pushed a commit that referenced this pull request Oct 4, 2018
The tests in <nixos/tests/installer.nix> are using `parted`, so they are
bound to be better tested than `fdisk`.

This is brought on by a couple issues, plus reports on IRC that the
`fdisk` instructions didn't work as expected.

 * #39354
 * #46309
 * #39942
 * #45478

Care was taken so that the other documented steps did not need changes.

In all this kerfufle, a slight re-organization of the Chapter has been
made, allowing better deep linking.

(cherry picked from commit 6cfbf40)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants