-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.python-forecastio: init at 1.4.0 #42052
Conversation
@GrahamcOfBorg build python2.pkgs.python-forecastio python3.pkgs.python-forecastio |
Success on x86_64-darwin (full log) Attempted: python2.pkgs.python-forecastio, python3.pkgs.python-forecastio Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: python2.pkgs.python-forecastio, python3.pkgs.python-forecastio Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: python2.pkgs.python-forecastio, python3.pkgs.python-forecastio Partial log (click to expand)
|
@@ -766,7 +766,7 @@ | |||
"sensor.cups" = ps: with ps; [ pycups ]; | |||
"sensor.currencylayer" = ps: with ps; [ ]; | |||
"sensor.daikin" = ps: with ps; [ ]; | |||
"sensor.darksky" = ps: with ps; [ ]; | |||
"sensor.darksky" = ps: with ps; [ python-forecastio ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this generated by parse-requirements.py
? The top of the file says "do not edit".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh oh :D i will look into it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran the command, however it was unable to detect the new dependency. now sure what to touch to make it work.
The package is called python-forecastio and will be installed with pip install python-forecastio
. (see https://github.com/ZeevG/python-forecast.io )
can you check the parse-requirements.py package what went wrong there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exactly, but how can i get the parse-requirements.py
to find this requirement and add it automatically to the list of components?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -766,7 +766,7 @@ | |||
"sensor.cups" = ps: with ps; [ pycups ]; | |||
"sensor.currencylayer" = ps: with ps; [ ]; | |||
"sensor.daikin" = ps: with ps; [ ]; | |||
"sensor.darksky" = ps: with ps; [ ]; | |||
"sensor.darksky" = ps: with ps; [ python-forecastio ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be a separate commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as discussed above, this should be done somehow automatically by the update script but it doesn't for some reason
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just tried running the parse-requirements.py
script here and it works perfectly fine. In addition to updating the darksky sensor
component it also updates the weather
component as expected. What happens when you run it?
As mentioned by @FRidh that needs to go into a separate commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parse-requirements.py
works for me as well. You should however rebase onto latest master, where Home Assistant was updated to 0.72.0.
propagatedBuildInputs = [ requests responses ]; | ||
|
||
checkPhase = '' | ||
nosetests --with-coverage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should be able to just drop --with-coverage
and the coverage
dependency above.
|
||
}; | ||
|
||
checkInputs = [ nose coverage responses ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for responses
here as it's in propagatedBuildInputs
8abb7b0
to
f8d30b1
Compare
i've added the changes requested, rebased onto latest master and i've put the regenerated component-packages into a separate commit. |
Success on x86_64-linux (full log) Attempted: home-assistant Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: home-assistant Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: home-assistant Partial log (click to expand)
|
There are 2 changes to the components file but one of them is in the wrong commit. |
f8d30b1
to
e5ff063
Compare
@peterhoeg you are right, i fixed that |
The file is still changed by the first commit. |
Success on x86_64-linux (full log) Attempted: home-assistant Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: home-assistant Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: home-assistant Partial log (click to expand)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as @dotlambda mentioned
adds python-forecastio to weather.darksky
e5ff063
to
5db01c5
Compare
... sorry for the fuckup, this is what happens when you try to manually revert changes in a commit instead of knowing the correct git command. |
Success on x86_64-darwin (full log) Attempted: home-assistant Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: home-assistant Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: home-assistant Partial log (click to expand)
|
Thanks @makefu! That Dark Sky API seems to be interesting indeed. |
Motivation for this change
add the python package to get the darksky home-assistant module to work.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
) - works with home-assistant