-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.slackclient:1.0.0 -> 1.2.1 | refactor #44155
Conversation
@GrahamcOfBorg build pythonPackages.slackclient python3Packages.slackclient |
Success on aarch64-linux (full log) Attempted: pythonPackages.slackclient, python3Packages.slackclient Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: pythonPackages.slackclient, python3Packages.slackclient Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: pythonPackages.slackclient, python3Packages.slackclient Partial log (click to expand)
|
checkInputs = [ pytest codecov coverage mock pytestcov pytest-mock responses flake8 ]; | ||
# test_server.py fails because it needs connection (I think); | ||
checkPhase = '' | ||
flake8 slackclient |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the package build should break because of coding style issue. This is more useful if applied upstream as it might break our builds if we update flake8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mic92 Yeah you are right, What you suggest then as a temporary fix/workaround ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can just remove this line from checkPhase
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, Thanks for the help
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)