vulkan: 1.1.77.0 -> 1.1.82.1 #45195

Ralith · 2018-08-17T06:09:06Z

Motivation for this change

Lockstep update of all vulkan packages.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

ajs124 · 2018-08-24T11:48:21Z

pkgs/development/compilers/glslang/default.nix


  src = fetchFromGitHub {
-    owner = "KhronosGroup";
+    owner = "lenny-lunarg";


Why change the source to this fork?

Upstream forked to backport an important bugfix. See KhronosGroup/Vulkan-ValidationLayers#252 for details. The source will be reverted in the next update.

Is it just one commit?

Looks that way. Are you thinking incorporating the patch nix-side would be better?

You can use the upstream url and fetchpatch then.

Ralith · 2018-08-24T18:43:55Z

Fixed refs. Annoyingly, upstream didn't tag 1.1.82.1 anywhere, though since it's only a glslang bump all the vulkan-* source is actually unchanged.

Mic92 · 2018-08-28T22:24:52Z

pkgs/development/libraries/vulkan-headers/default.nix

@@ -1,15 +1,15 @@
 { stdenv, fetchFromGitHub, cmake }:
 stdenv.mkDerivation rec {
  name = "vulkan-headers-${version}";
-  version = "1.1.77.0";
+  version = "1.1.82.1";


Does it have to be version = "1.1.82.1"; instead of version = "1.1.82.0";?

I could restrict the version change to -validation-layers; would that be preferable?

Keeping version and rev in sync looks less confusing to me.

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/vulkan-tools/versions.

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/vulkan-headers/versions.

Ralith · 2018-08-30T02:00:18Z

Reverted to more conservative versioning and switched to fetchpatch for the glslang fix.

Ralith · 2018-09-02T00:56:55Z

Any hope of getting this in time for the branch?

grahamc · 2018-09-02T01:18:07Z

@GrahamcOfBorg build vulkan-loader vulkan-validation-layers glslang-git spirv-tools vulkan-headers

GrahamcOfBorg · 2018-09-02T01:18:19Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: vulkan-loader, vulkan-validation-layers, glslang-git, spirv-tools, vulkan-headers

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-09-02T01:31:22Z

Success on aarch64-linux (full log)

Attempted: vulkan-loader, vulkan-validation-layers, spirv-tools, vulkan-headers

The following builds were skipped because they don't evaluate on aarch64-linux: glslang-git

Partial log (click to expand)

shrinking /nix/store/naggjggp6k4pndhjvf62gjbin9ffqysh-vulkan-validation-layers-1.1.82.0/lib/libVkLayer_object_tracker.so
shrinking /nix/store/naggjggp6k4pndhjvf62gjbin9ffqysh-vulkan-validation-layers-1.1.82.0/lib/libVkLayer_core_validation.so
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/naggjggp6k4pndhjvf62gjbin9ffqysh-vulkan-validation-layers-1.1.82.0/lib
patching script interpreter paths in /nix/store/naggjggp6k4pndhjvf62gjbin9ffqysh-vulkan-validation-layers-1.1.82.0
checking for references to /build in /nix/store/naggjggp6k4pndhjvf62gjbin9ffqysh-vulkan-validation-layers-1.1.82.0...
/nix/store/0fyajwrpjsjj1zgavfb0l5hr8p1xmw0k-vulkan-loader-1.1.82.0
/nix/store/naggjggp6k4pndhjvf62gjbin9ffqysh-vulkan-validation-layers-1.1.82.0
/nix/store/slh4ljsgx3hjsvf76kxwd81fjsavrvhs-spirv-tools-2018-07-04
/nix/store/49h8sa1k7zgn44q3awsf7mjp6xsxfnc5-vulkan-headers-1.1.82.0

GrahamcOfBorg · 2018-09-02T01:34:34Z

Success on x86_64-linux (full log)

Attempted: vulkan-loader, vulkan-validation-layers, spirv-tools, vulkan-headers

The following builds were skipped because they don't evaluate on x86_64-linux: glslang-git

Partial log (click to expand)

shrinking /nix/store/2w8h9y2a9lygd7shdazsk62k2vyvrsh0-vulkan-validation-layers-1.1.82.0/lib/libVkLayer_object_tracker.so
shrinking /nix/store/2w8h9y2a9lygd7shdazsk62k2vyvrsh0-vulkan-validation-layers-1.1.82.0/lib/libVkLayer_parameter_validation.so
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/2w8h9y2a9lygd7shdazsk62k2vyvrsh0-vulkan-validation-layers-1.1.82.0/lib
patching script interpreter paths in /nix/store/2w8h9y2a9lygd7shdazsk62k2vyvrsh0-vulkan-validation-layers-1.1.82.0
checking for references to /build in /nix/store/2w8h9y2a9lygd7shdazsk62k2vyvrsh0-vulkan-validation-layers-1.1.82.0...
/nix/store/jj0ja5p1sfcl8rqnfvcchaygrg3wwa6d-vulkan-loader-1.1.82.0
/nix/store/2w8h9y2a9lygd7shdazsk62k2vyvrsh0-vulkan-validation-layers-1.1.82.0
/nix/store/89vr7fygnhh7ibkkqx03mckgnrp55cwb-spirv-tools-2018-07-04
/nix/store/aysxshfzf9a8xy13mnflpcc0pz4z2ssb-vulkan-headers-1.1.82.0

This was referenced Aug 17, 2018

vulkan-tools: 1.1.77.0 -> 1.1.82.0 #45124

Closed

vulkan-headers: 1.1.77.0 -> 1.1.82.0 #45125

Closed

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 labels Aug 17, 2018

Ralith force-pushed the vulkan branch from 53cfca6 to c5e6e87 Compare August 24, 2018 03:35

Ralith changed the title ~~vulkan: 1.1.77.0 -> 1.1.82.0~~ vulkan: 1.1.77.0 -> 1.1.82.1 Aug 24, 2018

ajs124 reviewed Aug 24, 2018

View reviewed changes

Ralith force-pushed the vulkan branch from c5e6e87 to 8639a1b Compare August 24, 2018 18:42

Mic92 reviewed Aug 28, 2018

View reviewed changes

R. RyanTM and others added 6 commits August 29, 2018 18:56

vulkan-tools: 1.1.77.0 -> 1.1.82.0

88621e0

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/vulkan-tools/versions.

vulkan-headers: 1.1.77.0 -> 1.1.82.0

328cb60

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/vulkan-headers/versions.

spirv-tools: 2018-06-06 -> 2018-07-04

556c27e

glslang-git: 2018-06-21 -> 2018-07-27

c36382d

vulkan-loader: 1.1.77.0 -> 1.1.82.0

b830df0

vulkan-validation-layers: 1.1.77.0 -> 1.1.82.0

bf50cac

Ralith force-pushed the vulkan branch from 8639a1b to bf50cac Compare August 30, 2018 01:59

grahamc merged commit 121a7d7 into NixOS:master Sep 2, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

vulkan: 1.1.77.0 -> 1.1.82.1 #45195

vulkan: 1.1.77.0 -> 1.1.82.1 #45195

Ralith commented Aug 17, 2018

ajs124 Aug 24, 2018

Ralith Aug 24, 2018

Mic92 Aug 28, 2018

Ralith Aug 29, 2018

Mic92 Aug 29, 2018

Ralith commented Aug 24, 2018

Mic92 Aug 28, 2018

Ralith Aug 29, 2018

Mic92 Aug 29, 2018

Ralith commented Aug 30, 2018

Ralith commented Sep 2, 2018

grahamc commented Sep 2, 2018

GrahamcOfBorg commented Sep 2, 2018

GrahamcOfBorg commented Sep 2, 2018

GrahamcOfBorg commented Sep 2, 2018

vulkan: 1.1.77.0 -> 1.1.82.1 #45195

vulkan: 1.1.77.0 -> 1.1.82.1 #45195

Conversation

Ralith commented Aug 17, 2018

Motivation for this change

Things done

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ralith commented Aug 24, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ralith commented Aug 30, 2018

Ralith commented Sep 2, 2018

grahamc commented Sep 2, 2018

GrahamcOfBorg commented Sep 2, 2018

GrahamcOfBorg commented Sep 2, 2018

GrahamcOfBorg commented Sep 2, 2018