RFC: Add buildExternalNixExpression #4657
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjornfor
force-pushed
the
build-external-nix-expression
branch
from
3a86ee4
to
2f91bce
Compare
This function is for building (external) packages that contain a
default.nix file in their sources.
Example usage:
project-name = buildExternalNixExpression {
src = fetchurl { ... };
};
bjornfor
force-pushed
the
build-external-nix-expression
branch
from
2f91bce
to
e3ee56e
Compare
|
This requires an import from a derivation, which means: a) readonly queries will fail |
|
@shlevy: these are inherent to the problem at hand, not to this implementation, right? |
|
@vcunat Alternative solution without that problem is recursive nix (NixOS/nix#13) |
|
Ah, I can see now how this is side-stepped. I forgot how the #13 issue was meant. |
| @@ -261,6 +261,8 @@ let | |||
| inherit (pkgs) runCommand perl; | |||
| }; | |||
|
|
|||
| buildExternalNixExpression = callPackage ../build-support/build-external-nix-expression/default.nix { }; | |||
There was a problem hiding this comment.
This is not a package so you shouldn't use callPackage here.
|
Thanks for the feedback. Closing this then, and hoping for NixOS/nix#13 to be solved/implemented :-) |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My attempt at answering/solving the "upstream nix expressions" question in http://lists.science.uu.nl/pipermail/nix-dev/2014-October/014734.html.
Please have a look and give some feedback :-)
This function is for building (external) packages that contain a
default.nix file in their sources.
Example usage: