-
-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vim-tsx: init at 2017-03-16 #46728
vim-tsx: init at 2017-03-16 #46728
Conversation
pkgs/misc/vim-plugins/generated.nix
Outdated
@@ -375,17 +375,6 @@ | |||
}; | |||
}; | |||
|
|||
deoplete-jedi = buildVimPluginFrom2Nix { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is strange. This should have been not removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rebase your code to the latest master and try to regnerate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is a bug in the vim updater. I've been trying to add some vim packages and ./updater.py removed some untouched plugins (supertab for instance) from generated.nix which makes the updater fails teh second time. Maybe it should generate a diff and ask for confimaton before overwriting the generated.nix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in d499b7d...dec78a2
Oh OK so I've found the root issue would have been that my system didn't have |
aa55beb
to
ff8a092
Compare
So the required I think this fixes the issues and can now be merged 😄 |
oh, now I already have added nix-prefetch-git. |
Cherry-picked in 0e1f3ef |
Motivation for this change
Add a plugin for vim that does highlighting for typescript jsx.
example usage:
Then you can view a tsx file. This is an example file you could download to test.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)