Pleasant ruby

[cstrahan]

This is a continuation of @joelteon's excellent work in #3491.

[cstrahan]

@iElectric @7c6f434c @Phreedom

This is actually almost done - maybe another hour or two of work. The plan is to merge this in tomorrow and send a message to the mailing list.

Concretely, the only thing left to do is allow for sending gem build arguments through bundler (e.g. "--with-xml2-lib=${libxml2}/lib").

It's rather frustrating that this dragged out for so long, but there were a number of subtle challenges going with the general approach that I co-authored with @joelteon and @aflatter. We were serializing the Gemfile.lock as a nix expression, which was (and still is) fantastic, but then we were trying to make the RubyGem resolution work by installing the gems via gem install and manipulating $GEM_PATH, rather than letting bundler do proper loading. This posed a number of problems: as a developer, I couldn't point bundle exec at the build artifacts, frameworks that try to use Bundler.require(:default) completely explode, etc. So a couple days ago I said "screw it, I'll just rewrite the damned thing".

I now have a system in place that hooks into bundler and lets it do the whole install. It's absolutely wonderful, and seems to work really, really well. I'll write up more details in the email I'm going to send tomorrow.

[domenkozar]

🍻

[cstrahan]

Going to merge this in the next hour.

[peti]

It appears that this change broke evaluation of

• gist,
• gitlab,
• gitlab-shell,
• gem-nix, and
• loadRubyEnv.

Just run nix-env -qa to see the errors.

[peti]

@cstrahan, it's kind-of customary that people who commit a change that breaks other packages make an effort to fix the breakage. I believe that your commit broke gitlab and several other packages (see my previous comment). Do you intend to do anything about that?

[jgeerds]

@cstrahan This breaks also python2.7-pync-1.4

[jgeerds]

@cstrahan Are you working on this? (terminal_notifier)

[cstrahan]

@cstrahan, it's kind-of customary that people who commit a change that breaks other packages make an effort to fix the breakage. I believe that your commit broke gitlab and several other packages (see my previous comment). Do you intend to do anything about that?

I'm sorry - I didn't see a GitHub notification for the comments on this thread.

It appears that this change broke evaluation of

• gist,
• gitlab,
• gitlab-shell,
• gem-nix, and
• loadRubyEnv.

I resolved those a couple days ago after @iElectric pointed them out to me on IRC. GitLab currently builds, but I still need to test running the service.

@cstrahan Are you working on this? (terminal_notifier)

Yes, I'll have that fixed shortly.

[cstrahan]

@cstrahan Are you working on this? (terminal_notifier)

Fixed in:

5a73cda

[jgeerds]

Thanks! 😄

[domenkozar]

Thanks @cstrahan, appreciated