-
-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos on hyperv: load proper modules and make installer use the module #47482
Conversation
What would you think about also adding an option in the hypervGuest section which would trigger Sorry I'll not be able to test this, but I uninstalled HyperV from my Windows notebook in the end, as I grew tired of trying to use NixOS that way (the machine had too little memory to do this comfortably while also "living normally" with a memory-hungry web browser on Windows). Would you mind also editing the relevant nixos-hardware "guide" to take into account your simplifications after this PR hopefully gets merged? As to your comment about BIOS vs. UEFI, I'm not even sure if my machine is BIOS- or UEFI-based... so won't be able to discuss this more too, I'm afraid... I just dumped into nixos-hardware whatever I found helped me, in hope that other people might find it useful too... |
The memory issue was addressed in NixOS/nix@2825e05 so the overcommit workaround should no longer be needed - this isn't specific to hyperv.
It's not about the host machine - the VM can be created as gen1 (BIOS) or gen2 (UEFI). With the mentioned PR, there really shouldn't be anything needed to boot on HyperV - it should just work. Then you guide could cover file sharing as well as the gen1/gen2 distinction for the boot loader. |
This seems safe to affect hyper-v only, so I'd not block that, if it gets some confidence through review, testing, etc. (Even if to be merged after official release.) |
This PR is a cleanup of the configuration we have had running for customers in production for months so it should be safe. I'll deploy this exact configuration and merge if all OK. |
Motivation for this change
We run quite a bit of NixOS on HyperV and have had a number of changes in use that were never upstreamed. I'm trying to rectify that.
Would love for some people who run on HyperV to test this out.
Cc: @akavel
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)