haskell: fix x509-system on mojave #47676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LnL7
approved these changes
Oct 2, 2018
| @@ -132,7 +132,7 @@ self: super: builtins.intersectAttrs super { | |||
| then let inherit (pkgs.darwin) security_tool; | |||
| in pkgs.lib.overrideDerivation (addBuildDepend super.x509-system security_tool) (drv: { | |||
| postPatch = (drv.postPatch or "") + '' | |||
| substituteInPlace System/X509/MacOS.hs --replace security ${security_tool}/bin/security | |||
| substituteInPlace System/X509/MacOS.hs --replace security /usr/bin/security | |||
There was a problem hiding this comment.
could you add a FIXME comment or something
|
Yeah - the backport to 18.03 and 18.09 would be permanent, but we should be able to get things up to date for 19.03. It will all depend on whether there are any side effects from updating stuff. |
|
I didn't backport the Mojave changes to 18.03 yet, but yeah keeping this there is fine since fixing it properly would imply pulling in a significant amount of stdenv/sdk changes. |
darwin.security_tool is currently broken in Mojave. See issue NixOS#45042 for more info. Our security_tool stuff comes from 10.9 so I suspect that it needs an update. Here I am putting in a hack to get things working again. This uses the system provided security binary at /usr/bin/security to avoid the issue in Haskell’s x509-system package. Unfortunately, this will break with the sandbox. I am also working on a proper fix, but this requires updating lots of Apple stuff (and also copumpkin’s new CF). You can follow the progress on this branch: https://github.com/matthewbauer/nixpkgs/tree/xcode-security This commit should be backported to release-18.03 and release-18.09. /cc @copumpkin @LnL7 @pikajude
matthewbauer
force-pushed
the
security-mojave-fix
branch
from
5b77a04
to
300ff96
Compare
|
Is there anywhere I can track the backport progress? I'd like to make sure I bump things in reflex-platform, which is currently tracking 18.09, as soon as possible. |
|
It should be in the channel already 79bbe4d. @matthewbauer Use git cherry-pick -x next time, that makes it easier to find. |
yorickvP
referenced
this pull request
Dec 13, 2018
michaelpj
pushed a commit
to input-output-hk/haskell.nix
that referenced
this pull request
Dec 16, 2020
This mirrors the workaround in nixpkgs for haskellPackages. ref: NixOS/nixpkgs#47676
booniepepper
pushed a commit
to booniepepper/haskell.nix
that referenced
this pull request
Feb 4, 2022
This mirrors the workaround in nixpkgs for haskellPackages. ref: NixOS/nixpkgs#47676
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
darwin.security_tool is currently broken in Mojave. See issue #45042
for more info. Our security_tool stuff comes from 10.9 so I suspect
that it needs an update.
Here I am putting in a hack to get things working again. This uses the
system provided security binary at /usr/bin/security to avoid the
issue in Haskell’s x509-system package. Unfortunately, this will break
with the sandbox. I am also working on a proper fix, but this requires
updating lots of Apple stuff (and also copumpkin’s new CF). You can
follow the progress on this branch:
https://github.com/matthewbauer/nixpkgs/tree/xcode-security
This commit should be backported to release-18.03 and release-18.09.
/cc @copumpkin @LnL7 @pikajude