-
-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
postgresql_11: init at 11.0 #48664
postgresql_11: init at 11.0 #48664
Conversation
Success on aarch64-linux (full log) Attempted: postgresql10, postgresql11 Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: postgresql10, postgresql11 Partial log (click to expand)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not been really looking at it for the moment, but do we want to add an option in the service to enable the new JIT capabilities for pg-11 (I think it is only a runtime dependency to the LLVM infrastructure, but I have to check)?
As far as I can see, this breaks the nixos/tests/postgis.nix
test (which tests postgresql10 + postgis, so it uses the old postgresql100
attribute name). Can you update this as well ? Ideally, it should test all versions of postgresql with postgis, but only bumping to postgres11 should be fine.
(and thanks for the PR of course!) |
JIT support requires a configure time flag: https://www.postgresql.org/docs/11/static/install-procedure.html#CONFIGURE-WITH-LLVM I am not saying we should set that up now, just wondering if we should introduce an option to support it. |
I'd keep ```postgresql100```
But Postgresql100 points to 10.5! I don't think that's very good naming at all.
If you insist on renaming, there are 2 things to consider
* old name is to be added to ```aliases.nix``` in order not to break user code which uses the old name.
Happy to do this.
* why not to rename to ```postgresql_10``` ? ```small-L``` following by ```1``` is not very readable: ![](http://i.imgur.com/HIxqkTw.png)
Because that would be inconsistent with the rest of nixpkgs. This is less of an issue with nixpkgs and more of an issue with your choice of font!
|
On further investigation I note that there are packages that separate name and version with an underscore, eg ruby_2_4. But most seem to be in the |
Success on x86_64-linux (full log) Attempted: postgresql10, postgresql11 Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: postgresql10, postgresql11 Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: postgresql10, postgresql11 Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: postgresql10, postgresql11 Partial log (click to expand)
|
Agreed. I'll fix those and add aliases. |
Done! Had to rebase to avoid a conflict in the release notes. |
Looks like you have re-introduced the JIT related commit (the one that compiles everything with clang instead of gcc) |
Success on aarch64-linux (full log) Attempted: postgresql_11 Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: postgresql_11 Partial log (click to expand)
|
Ah whoops, so I had. Fixed. |
Success on aarch64-linux (full log) Attempted: postgresql_11 Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: postgresql_11 Partial log (click to expand)
|
@@ -694,7 +694,7 @@ in | |||
# container so that container@.target can get the container | |||
# configuration. | |||
environment.etc = | |||
let mkPortStr = p: p.protocol + ":" + (toString p.hostPort) + ":" + (if p.containerPort == null then toString p.hostPort else toString p.containerPort); | |||
let mkPortStr = p: p.protocol + ":" + (toString p.hostPort) + ":" + (if p.containerPort == null then toString p.hostPort else toString p.containerPort); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if I see that this changes nothing, I think it is better for tractability to leave this line unchanged (at least in the context of postgresql updates) (I guess you have automated white space stripping in your text editor).
Success on aarch64-linux (full log) Attempted: postgresql_11 Partial log (click to expand)
|
Good for me, merged. Thanks @alyssais for the work, and sorry it took so long. |
Success on x86_64-linux (full log) Attempted: postgresql_11 Partial log (click to expand)
|
JIT support will be handled by #38698 once it's merged, JFYI. |
Motivation for this change
I've renamed
postgres100
topostgres10
as part of this change, because100
implies Nix packages multiple versions of Postgresql 10, which it does not. This is similar to how we do things for eg OpenSSL (#46524).Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)