New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ntp default restrictions #50762
Merged
Merged
Ntp default restrictions #50762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reardencode
requested review from
basvandijk,
edolstra,
edwtjo,
Ericson2314,
FRidh,
infinisil,
LnL7,
matthewbauer,
Mic92,
nbp,
peti,
Profpatsch,
ryantm,
thoughtpolice,
ttuegel and
zimbatm
as code owners
November 19, 2018 17:59
reardencode
force-pushed
the
ntp-default-restrictions
branch
from
November 19, 2018 18:01
f4de05f
to
96a10be
Compare
Mic92
removed request for
zimbatm,
thoughtpolice,
ryantm,
matthewbauer,
peti,
edwtjo,
Mic92,
ttuegel,
basvandijk,
LnL7,
Ericson2314 and
edolstra
November 19, 2018 18:03
sorry about that initial push - failed to push rebase onto master. |
Mic92
reviewed
Nov 19, 2018
In https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-1903.xml we should mention the new defaults. Some people maybe rely on them. |
Mic92
reviewed
Nov 20, 2018
Mic92
reviewed
Nov 20, 2018
Mic92
reviewed
Nov 20, 2018
infinisil
requested changes
Nov 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
#50732
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)