Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ntp default restrictions #50762

Merged
merged 4 commits into from Nov 28, 2018
Merged

Conversation

reardencode
Copy link
Contributor

Motivation for this change

#50732

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@reardencode
Copy link
Contributor Author

sorry about that initial push - failed to push rebase onto master.

@Mic92
Copy link
Member

Mic92 commented Nov 19, 2018

In https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-1903.xml we should mention the new defaults. Some people maybe rely on them.

nixos/modules/services/networking/ntpd.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/ntpd.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/ntpd.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/ntpd.nix Outdated Show resolved Hide resolved
@Mic92 Mic92 merged commit dacbd5a into NixOS:master Nov 28, 2018
@reardencode reardencode deleted the ntp-default-restrictions branch November 28, 2018 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants