-
-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nextcloud-client: switch to libsecret and use it by default #51044
nextcloud-client: switch to libsecret and use it by default #51044
Conversation
This change makes it easier for users to setup the nextcloud client with GNOME keyring support as discussed in the IRC[1][2]. Additionaly we now use `libsecret` instead of `libgnome-keyring` which integrates better in a GNOME setup (libgnome-keyring defaults to the Gnome2 library)[3]. [1] https://logs.nix.samueldr.com/nixos/2018-11-24#1745871; [2] https://logs.nix.samueldr.com/nixos/2018-11-24#1746033; [3] NixOS#38266
cc @jtojnar |
LGTM. cc @alexeymuranov can you test this? |
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: nextcloud-client Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: nextcloud-client Partial log (click to expand)
|
Failure on aarch64-linux (full log) Attempted: nextcloud-client Partial log (click to expand)
|
I havn't tried to test it yet, but here are a few observations about nextcloud-client version 2.5.0. It seems to be quite different from version 2.3.3 and incompatible with it: upgrading-downgrading-upgrading seems to cause losing connection configuration. There are a number of issue reported about version 2.5.0, and on Ubuntu i experienced file disappearance with it. |
@M-Gregoire thanks a lot for your detailed feedback! I'll look into it tomorrow. @alexeymuranov I doubt that they actively support downgrades. Before I filed #50463 I tested this on my local Nextcloud setup and it managed to migrate my configurations and it found an existing sync in |
@Ma27, they are free to support or not support symlinks, but when files disappear, it is a bug IMO, and if symlinks are not supported, no changes to directory contents should be made, and otherwise synchronisation should be done properly. |
@Ma27 Upon testing, within gnome3, I did notice the first issue @M-Gregoire pointed out. I've also tested kwallet and it operates correctly. |
hmm... I use my change already in my local setup and it works fine. Simply opening
Not sure either. But please not that there's
I don't think so. I figured that if the daemon is running, this should be fine.
Which prompt do you mean? When I login in a fresh setup, the keyring asks me to unlock it with my master passphrase and then I'm logged in. Btw the more I think about this: is it possible that you had 2.3 before testing this? I'm not sure, but this may be related to the config "migration" that happens when using the 2.5 client with 2.3 config.
Thanks for trying this out. Maybe this is gnome related (as said, I couldn't reproduce this yet), I'll try this out in a Gnome VM later this week ;) |
@Ma27 Thank you for your extensive answer! I will try to investigate further. Note that I'm not using Gnome but i3, I only use gnome3 services to enable the keyring
I'm unsure this is the best way to do it however. I've also noticed though I'll keep you updated. |
The actual testing I did was within a gnome vm, forgot to mention that. |
I don't know enough about the keyring to help you here. Is this a known issue? Otherwise I'd recommend to you ask in |
I've migrated to |
nixpkgs now uses nextcloud-client v2.5.1 since #52354, does this fix the issues for some of you here? |
@Ma27 Thank you for updating |
cc @flokli do you have an idea how this could be related to |
@M-Gregoire, @Ma27 I might not be the most qualified person, given I don't run a kde environment, but i3 with All I can tell is that every time I start nextcloud-client, a |
@M-Gregoire I'm getting the same @Ma27 Is there any chance to override |
On 18.09 you need to override I'll check tomorrow if there's a need to backport the most recent patches ok? :) |
Ah sorry, missed that. I don't use unstable, so I didn't notice, but nextcloud-client indeed breaks on startup on unstable. I have a theory what's causing this, I'll try to fix it :) |
The QT_PLUGIN_PATH couldn't find the needed xcb plugin. See also NixOS#51044
can you please have a look at #54484, I can run |
The QT_PLUGIN_PATH couldn't find the needed xcb plugin. See also NixOS#51044
Motivation for this change
This change makes it easier for users to setup the nextcloud client with
GNOME keyring support as discussed in the IRC[1][2].
Additionaly we now use
libsecret
instead oflibgnome-keyring
whichintegrates better in a GNOME setup (libgnome-keyring defaults to the
Gnome2 library)[3].
[1] https://logs.nix.samueldr.com/nixos/2018-11-24#1745871;
[2] https://logs.nix.samueldr.com/nixos/2018-11-24#1746033;
[3] #38266
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after) (as stated in the commit message it has been discussed about this, we accept the increased closure size for usability)