Skip to content

Fluidsynth 1 #52361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 18, 2018
Merged

Fluidsynth 1 #52361

merged 4 commits into from
Dec 18, 2018

Conversation

rardiol
Copy link
Contributor

@rardiol rardiol commented Dec 16, 2018

Motivation for this change

csound needs fluidsynth 1, see csound/csound#1078

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rardiol
Copy link
Contributor Author

rardiol commented Dec 16, 2018

cc @MarcWeber @cillianderoiste @lovek323

@GrahamcOfBorg GrahamcOfBorg added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Dec 16, 2018
@lheckemann
Copy link
Member

LGTM.

@GrahamcOfBorg build csound fluidsynth

lheckemann
lheckemann reviewed Dec 16, 2018
View reviewed changes
pkgs/applications/audio/fluidsynth/default.nix
stdenv.mkDerivation rec {
name = "fluidsynth-${version}";
version = "2.0.1";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it would be good to leave the fluidsynth 2.x derivation unchanged, thus avoiding a mass-rebuild. You'd just need to add the version line back as version = fluidsynthVersion;.

@lheckemann
fluidsynth: keep version
6bdcc10 
This avoids a mass-rebuild for packages which depend on fluidsynth 2.x.
@lheckemann
Copy link
Member

I've taken the liberty of adding this myself, which means that fluidsynth 2.x's derivation doesn't change at all, which in turn avoids a large number of rebuilds.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Dec 18, 2018
@lheckemann lheckemann merged commit 70658b2 into NixOS:master Dec 18, 2018
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 18, 2018
@rardiol rardiol deleted the fluidsynth_1 branch December 20, 2018 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lheckemann lheckemann lheckemann left review comments

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rardiol @lheckemann @GrahamcOfBorg