-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
datadog-agent: 6.4.2 -> 6.8.3 #52765
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to see this in 18.09 too.
@GrahamcOfBorg build datadog-agent |
Does the package work @Izorkin? It would be good to have even a little sentence in your PR description on what you tested. |
In linux kernel 4.14 datadog v6.4.2 and v6.8.2 normal work. |
Fixed check disk in this PR #53141 |
Update to 6.8.3 |
@@ -186,7 +186,7 @@ in { | |||
type = types.attrs; | |||
default = { | |||
init_config = {}; | |||
instances = [ { use-mount = "no"; } ]; | |||
instances = [ { use-mount = "false"; } ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this change for? Was the old value invalid?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This parameter found in example config https://github.com/DataDog/datadog-agent/blob/master/cmd/agent/dist/conf.d/disk.d/conf.yaml.default#L6
Thanks! |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)