Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thunderbird: 60.3.3 -> 60.4.0 #53437

Closed
wants to merge 2 commits into from
Closed

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Jan 5, 2019

Motivation for this change

NOTE: thunderbird-bin is broken in my environment. If you cannot run it, please merge only thunderbird package.

  • bugfixes and other updates

https://www.thunderbird.net/en-US/thunderbird/60.4.0/releasenotes/

Running thunderbird-bin results in the following error:

ExceptionHandler::GenerateDump cloned child 25218
ExceptionHandler::SendContinueSignalToChild sent continue signal to child
ExceptionHandler::WaitForContinueSignal waiting for continue signal...

Adding libxcb, ibXcursor, and libXi doesn't help. It doesn't work with a fresh profile. With --headless option, the error is not produced.

The thunderbird package works fine.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vcunat
Copy link
Member

vcunat commented Jan 5, 2019

-bin crashes for me as well, so let's leave that out, at least for now.

@vcunat
Copy link
Member

vcunat commented Jan 5, 2019

@GrahamcOfBorg build thunderbird

Kirens pushed a commit to kirens-dotfiles/nixpkgs that referenced this pull request Jan 5, 2019
Picked from PR NixOS#53437.  It runs fine for me.
@vcunat
Copy link
Member

vcunat commented Jan 5, 2019

I assume there's no need to backport to 18.09 quickly (no really important fixes in release notes). I'm leaving this open for the -bin bump.

@andir
Copy link
Member

andir commented Jan 30, 2019

Closing this since 60.5.0 has landed already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants