Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thunderbird, thunderbird-bin: 60.4.0 -> 60.5.0 #54935

Merged
merged 2 commits into from Jan 30, 2019
Merged

thunderbird, thunderbird-bin: 60.4.0 -> 60.5.0 #54935

merged 2 commits into from Jan 30, 2019

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Jan 30, 2019

Motivation for this change
  • Critical security fixes
  • Other fixes and updates

https://www.thunderbird.net/en-US/thunderbird/60.5.0/releasenotes/
https://www.mozilla.org/en-US/security/advisories/mfsa2019-03/

thunderbird-bin is still broken.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@7c6f434c 7c6f434c merged commit 3106cbe into NixOS:master Jan 30, 2019
@andir
Copy link
Member

andir commented Jan 30, 2019

@taku0 what kind of crash are you still seeing with -bin? It seems to work just fine for me.
2019-01-30-165627_394x143_scrot

@taku0
Copy link
Contributor Author

taku0 commented Jan 31, 2019

Starting thunderbird results in the following message and Crash Reporter.

ExceptionHandler::GenerateDump cloned child 26521
ExceptionHandler::SendContinueSignalToChild sent continue signal to child
ExceptionHandler::WaitForContinueSignal waiting for continue signal...

--safe-mode doesn't help. --headless mode is fine while --ProfileManager is not, so it may be related to GUI.

@taku0
Copy link
Contributor Author

taku0 commented Jan 31, 2019

See also #53437 (comment)

@7c6f434c
Copy link
Member

Works for me, Intel GPU (I have a feeling it might be relevant… something about OpenGL in Gecko)

@taku0
Copy link
Contributor Author

taku0 commented Jan 31, 2019

GPU: Intel Open Source Technology Center -- Mesa DRI Intel(R) Iris Pro Graphics 580 (Skylake GT4e)
Driver: 3.0 Mesa 18.1.7

thunderbird (not -bin) works fine. firefox-bin also works fine.

andir pushed a commit that referenced this pull request Feb 7, 2019
@taku0 @andir
thunderbird, thunderbird-bin: 60.4.0 -> 60.5.0 (#54935)
e6ad2c3 
* thunderbird-bin: 60.3.3 -> 60.5.0

* thunderbird: 60.4.0 -> 60.5.0

(cherry picked from commit 3106cbe)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbp nbp Awaiting requested review from nbp

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@taku0 @andir @7c6f434c @dotlambda @GrahamcOfBorg