Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alsaLib: add upstream pcm interval patch to fix audio #53552

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@MP2E
Copy link
Contributor

commented Jan 7, 2019

fixes audio for Audacious, Old School Runescape (yet to be packaged, but I'm working on that!),
and a few other packages, see the following issues:

https://bugs.archlinux.org/task/60591?project=1&string=alsa-lib
https://bugzilla.redhat.com/show_bug.cgi?id=1640602
http://git.alsa-project.org/?p=alsa-lib.git;a=commitdiff;h=b420056604f06117c967b65d43d01536c5ffcbc9

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@MP2E MP2E changed the title alsaLib: upstream pcm interval patch to fix audio alsaLib: add upstream pcm interval patch to fix audio Jan 10, 2019

@MP2E

This comment has been minimized.

Copy link
Contributor Author

commented Jan 10, 2019

Cleaned up the commit message and pushed to staging as of 40ce44f, since I have tested this package for the past few weeks and ofborg found no issues, and because I don't see any maintainers to ping. Furthermore, other linux distributions have had this patch included in their alsa-lib packages for enough time that any serious regressions would have been reported

Nonetheless, please feel free to ping me about any issues that might arise and I'd be happy to help fix it, or revert.

@MP2E MP2E closed this Jan 10, 2019

@MP2E MP2E deleted the MP2E:alsa_lib_pcm_fix branch Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.