Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.xml2rfc: fix build #53724

merged 2 commits into from
Jan 10, 2019


Copy link

@Ma27 Ma27 commented Jan 10, 2019

Motivation for this change

Fixes the broken xml2rfc package by adding several python libraries to the build inputs list. The dependency google-i18n-address had to be packaged.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits

Copy link

Seeing warnings like

WARNING: Unable to find a suitible cache directory to write to, trying the following directories:
Try giving a specific directory with --cache.

when the tests are ran. Not sure if it's important.

Also seeing six in requirements.txt and it's missing here.

Adds the missing dependencies `google-i18n-address`, `pycountry` and
`html5lib` from the `pythonPackages` subtree.

See also
Copy link
Member Author

Ma27 commented Jan 10, 2019

when the tests are ran. Not sure if it's important.

Could be fixed by setting HOME to a temporary directory in the check phase.

Also seeing six in requirements.txt and it's missing here.

Good catch! Not exactly sure why it built successfully, but I added this for now :)

Copy link

@GrahamcOfBorg build pythonPackages.xml2rfc python3Packages.xml2rfc

@worldofpeace worldofpeace merged commit 338a5c3 into NixOS:master Jan 10, 2019
Copy link

btw, thanks for the round of fixes @Ma27 ❇️

@Ma27 Ma27 deleted the fix-py-xml2rfc branch January 10, 2019 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants