New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.xml2rfc: fix build #53724

Merged
merged 2 commits into from Jan 10, 2019

Conversation

Projects
None yet
3 participants
@Ma27
Copy link
Member

Ma27 commented Jan 10, 2019

Motivation for this change

Fixes the broken xml2rfc package by adding several python libraries to the build inputs list. The dependency google-i18n-address had to be packaged.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 force-pushed the Ma27:fix-py-xml2rfc branch from 0516bb0 to 30b5ad0 Jan 10, 2019

@worldofpeace

This comment has been minimized.

Copy link
Member

worldofpeace commented Jan 10, 2019

Seeing warnings like

WARNING: Unable to find a suitible cache directory to write to, trying the following directories:
  /var/cache/xml2rfc
  /homeless-shelter/.cache/xml2rfc
Try giving a specific directory with --cache.

when the tests are ran. Not sure if it's important.

Also seeing six in requirements.txt and it's missing here.

pythonPackages.xml2rfc: fix build
Adds the missing dependencies `google-i18n-address`, `pycountry` and
`html5lib` from the `pythonPackages` subtree.

See also https://hydra.nixos.org/build/86535305

@Ma27 Ma27 force-pushed the Ma27:fix-py-xml2rfc branch from 30b5ad0 to 9126dde Jan 10, 2019

@Ma27

This comment has been minimized.

Copy link
Member Author

Ma27 commented Jan 10, 2019

when the tests are ran. Not sure if it's important.

Could be fixed by setting HOME to a temporary directory in the check phase.

Also seeing six in requirements.txt and it's missing here.

Good catch! Not exactly sure why it built successfully, but I added this for now :)

@worldofpeace

This comment has been minimized.

Copy link
Member

worldofpeace commented Jan 10, 2019

@GrahamcOfBorg build pythonPackages.xml2rfc python3Packages.xml2rfc

@worldofpeace worldofpeace merged commit 338a5c3 into NixOS:master Jan 10, 2019

10 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@worldofpeace

This comment has been minimized.

Copy link
Member

worldofpeace commented Jan 10, 2019

btw, thanks for the round of fixes @Ma27 ❇️

@Ma27 Ma27 deleted the Ma27:fix-py-xml2rfc branch Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment