/nixpkgs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexget 2.17.20: add transmissionrpc as dependency #53735

Merged
merged 2 commits into from Jan 10, 2019

Conversation

Reviewers

@dotlambda dotlambda

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
3 participants
@agentpt5 @dotlambda @GrahamcOfBorg
@agentpt5
Copy link
Contributor

agentpt5 commented Jan 10, 2019

Motivation for this change

Some entries from propagatedBuildInputs were removed from the latest flexget upgrade. One such removed dependency is transmissionrpc, which is needed for flexget to communicate with transmission client. The one and only change of this pull request is to add back transmissionrpc to propagatedBuildInputs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@agentpt5
Add transmissionrpc as dependency to flexget, in order to communicate… 
… with Transmission networking client.
Loading status checks…
80b49af

@agentpt5 agentpt5 referenced this pull request Jan 10, 2019

Merged

flexget: 2.17.14 -> 2.17.20 #52681

4 of 10 tasks complete

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jan 10, 2019

@dotlambda

dotlambda reviewed Jan 10, 2019
View changes

Show resolved Hide resolved pkgs/applications/networking/flexget/default.nix Outdated
@dotlambda @agentpt5
Update pkgs/applications/networking/flexget/default.nix 
Co-Authored-By: agentpt5 <nelson@fwgi.com>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fdfe5c2

@dotlambda dotlambda merged commit 2f1e8d4 into NixOS:master Jan 10, 2019
10 checks passed

10 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details

@agentpt5 agentpt5 deleted the agentpt5:flexget-add-transmissionrpc branch Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment