Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulseeffects: fix functionality for non-GNOME environments #53857

Closed
wants to merge 1 commit into from

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jan 12, 2019

Motivation for this change

Until now pkgs.pulseeffects only worked on GNOME-like environments and didn't work in different desktop environments (in my case i3wm as window manager and a simple X session init script).

Icons now work and settings can be persisted.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This fixes missing icons on non-GNOME environments.
@flokli
Copy link
Contributor

flokli commented Jan 12, 2019

@Ma27 do we need this, or is wrapGAppsHook good enough (due to 670744e)

@jtojnar
Copy link
Contributor

jtojnar commented Jan 12, 2019

DConf GSettings module requires a DConf service. In my experience, this is achieved by adding dconf to services.dbus.packages (which has been recently done in #46058), environment.systemPackages should not be necessary,.

@Ma27
Copy link
Member Author

Ma27 commented Jan 12, 2019

First of all thanks a lot for your fast feedback!

You're right I guess. I removed the systemPackages statement from the dconf module. The change to pulseeffects fixes the problem for me. With having programs.dconf.enable = true I now can use pulseeffects in my desktop environments (and actually change Pulse settings).

@Ma27 Ma27 changed the title WIP pulseeffects: fix functionality for non-GNOME environments pulseeffects: fix functionality for non-GNOME environments Jan 12, 2019
@jtojnar
Copy link
Contributor

jtojnar commented Jan 12, 2019

I am discussing the icons here: #43150 (comment)

@Ma27
Copy link
Member Author

Ma27 commented Jan 12, 2019

so let's discuss the issue there and merge or close this PR depending on the result?

@peti
Copy link
Member

peti commented Apr 28, 2019

Is this PR still relevant?

@Ma27
Copy link
Member Author

Ma27 commented Apr 28, 2019

I guess not, if the addition can be that simple :)

@Ma27 Ma27 closed this Apr 28, 2019
@Ma27 Ma27 deleted the fix-pulseeffects-env branch April 28, 2019 17:59
@Ma27 Ma27 mentioned this pull request May 10, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants