-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xdg-desktop-portal{,-gtk}: 1.1.0 -> 1.2.0 #54299
xdg-desktop-portal{,-gtk}: 1.1.0 -> 1.2.0 #54299
Conversation
No package 'gdk-pixbuf-2.0' found |
Looking at flatpak/xdg-desktop-portal@c2bc33b, we might also need librsvg. |
Oh, sorry I missed those commits since they weren't adjacent 😇. It should at least build, and seems to work for me once so.... Okay here: dtzWill@cb783b3 (I'll pick when next back on my machine), not sure about librsvg. |
I guess Though it looks like they switched to validator from flatpak today. |
The path will need to be patched: https://github.com/flatpak/xdg-desktop-portal/pull/290/files#diff-4a78fe4a1e47fe57fc0581a862ffabd2R408 |
Bah it is messy flatpak/xdg-desktop-portal#289 maybe we should wait to see how it plays out. |
@GrahamcOfBorg build xdg-desktop-portal xdg-desktop-portal-gtk |
|
0684a35
to
f1e86ab
Compare
flatpak 1.2.0-- should I submit separately or update with these? https://github.com/dtzWill/nixpkgs/tree/update/flatpak-1.2.0 FWIW :). |
I’d update with these since they are mutually dependent. |
f1e86ab
to
a583786
Compare
Got the latest flatpak update in here. @jtojnar Any comments to get things moving again? |
Was this addressed yet? |
Don't think so, I'll add a patch for @GrahamcOfBorg build nixosTests.flatpak |
Thanks, that looks good. |
Running tests locally since they seem to time out here. |
Anything missing here? We probably want this in 19.03 right. |
@hedning I don't think so, I ran the tests locally and it seemed fine. I'd say let's go for 👍 |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)