Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flameshot: fix executable path in dbus service #55323

Merged
merged 1 commit into from Feb 8, 2019
Merged

Conversation

@Mic92
Copy link
Member

@Mic92 Mic92 commented Feb 6, 2019

Motivation for this change

also some minor tweaks that makes the package more robust.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

also some minor tweaks that makes the package more robust.
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Looks good, a possible follow up pr could be a nixos module.

Though It is annoying to have a bunch of those for dbus services.

@Mic92 Mic92 merged commit 61029df into NixOS:master Feb 8, 2019
13 checks passed
@Mic92
Copy link
Member Author

@Mic92 Mic92 commented Feb 8, 2019

We could probably get rid of most usages of services.dbus.packages by just pulling everything from environment.systemPackages instead by default.

@Mic92 Mic92 deleted the flameshot branch Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants