Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perlPackages.IOTty: fix darwin sandbox build #55659

Merged
merged 1 commit into from Feb 13, 2019
Merged

perlPackages.IOTty: fix darwin sandbox build #55659

merged 1 commit into from Feb 13, 2019

Conversation

@LnL7
Copy link
Member

@LnL7 LnL7 commented Feb 12, 2019

2 of the tests fail when sandboxing is enabled, we might want to allow
this case in the profile if there are more cases but for now just
disable the tests on darwin.

warning: TIOCSCTTY failed, slave might not be set as controlling terminal: Operation not permitted at /private/tmp/nix-build-perl5.28.1-IO-Tty-1.12.drv-0/IO-Tty-1.12/blib/lib/IO/Pty.pm line 121.
Error: could not connect pty as controlling terminal!
no controlling terminal at t/test.t line 68.
sysread() failed:  at t/test.t line 91.
# Looks like your test exited with 255 just after 2.
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

2 of the tests fail when sandboxing is enabled, we might want to allow
this case in the profile if there are more cases but for now just
disable the tests on darwin.

    warning: TIOCSCTTY failed, slave might not be set as controlling terminal: Operation not permitted at /private/tmp/nix-build-perl5.28.1-IO-Tty-1.12.drv-0/IO-Tty-1.12/blib/lib/IO/Pty.pm line 121.
    Error: could not connect pty as controlling terminal!
    no controlling terminal at t/test.t line 68.
    sysread() failed:  at t/test.t line 91.
    # Looks like your test exited with 255 just after 2.
@LnL7 LnL7 merged commit 1583db7 into NixOS:master Feb 13, 2019
10 checks passed
@LnL7 LnL7 deleted the perl-iotty branch Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants