Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pandoc: Enable distribution to fix master eval #56014

Merged
merged 1 commit into from Feb 18, 2019
Merged

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Feb 18, 2019

Motivation for this change

pandoc_2_6 has hydraPlatforms = stdenv.lib.platforms.none so I think the hackage2nix generator (or some other component) needs some more information so that master evals and thus grahamcofborg don't fail on nix-instantiate pkgs/top-level/release.nix -A pandoc.x86_64-linux

This is a workaround to keep the spice flowing.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@srhb
Copy link
Contributor Author

srhb commented Feb 18, 2019

@peti I can't figure out where the platforms get set to none for this version specifically, can you help with that for a more permanent fix? :)

@srhb
Copy link
Contributor Author

srhb commented Feb 18, 2019

Oh, it's exactly because it isn't in the default set.

Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems more than safe enough, for a temporary fix.

@vcunat vcunat merged commit dcdba11 into NixOS:master Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants