Update path in udev rule of mdadm #6006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @edolstra |
|
👍 |
|
Same should be done for |
|
udev-md-raid-arrays.rules does not contain any path that needs replacement, at least as far as I can see |
|
|
@iElectric, you're right, sorry, I didn't see the IMPORT rule. I've updated the PR. |
domenkozar
added a commit
that referenced
this pull request
Jan 29, 2015
Update path in udev rule of mdadm
|
@aszlig, thanks for pointing that out! So what do you suggest? |
|
@ts468 it's weird that it's not working for you, as it's patched by nixos: https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/services/hardware/udev.nix#L52 |
domenkozar
referenced
this pull request
Mar 30, 2015
This reverts commit 1faf610. It causes the size of the initrd to explode from ~6 MB to 19 MB: http://hydra.nixos.org/build/15728196 The reason is that mdadm now contains a self-reference: $ strings ./result/sbin/mdadm | grep /nix/store ... ACTION=="add", SUBSYSTEM=="block", ENV{DEVTYPE}=="%s", ENV{ID_PATH}=="%s", RUN+="/nix/store/y1ap6va0av6jhxf7ddnr8vdwxd7b44gd-mdadm-3.3.2/sbin/mdadm --incremental $env{DEVNAME}" ACTION=="add", SUBSYSTEM=="block", ENV{ID_PATH}=="%s", RUN+="/nix/store/y1ap6va0av6jhxf7ddnr8vdwxd7b44gd-mdadm-3.3.2/sbin/mdadm --incremental $env{DEVNAME}" /nix/store/y1ap6va0av6jhxf7ddnr8vdwxd7b44gd-mdadm-3.3.2/sbin/mdmon (Previously, it referred to /sbin/mdadm.) This causes mdadm, glibc and linux-headers to be added to the initrd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could you please check if that change makes sense? Something like that was required by nixos-rebuild.