Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.pysnooper: init at 0.3.0 #60228

Merged
merged 2 commits into from Jan 8, 2020
Merged

Conversation

@seqizz
Copy link
Contributor

@seqizz seqizz commented Apr 25, 2019

Motivation for this change

pysnooper is a python logging library, providing quick logging via decorator

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@seqizz seqizz force-pushed the seqizz:g_pysnooper branch 2 times, most recently from b353293 to 5511c5f Apr 26, 2019
Copy link
Member

@dotlambda dotlambda left a comment

Please make a separate commit for each package.

@seqizz seqizz force-pushed the seqizz:g_pysnooper branch from 5511c5f to e53d1f6 Apr 26, 2019
@seqizz
Copy link
Contributor Author

@seqizz seqizz commented Apr 26, 2019

Should be ok know, could you re-check. Also thanks for patience.

@seqizz seqizz force-pushed the seqizz:g_pysnooper branch 2 times, most recently from 86a4362 to cffc48b Apr 26, 2019
@seqizz seqizz changed the title pythonPackages.pysnooper: init at 0.0.21 pythonPackages.pysnooper: init at 0.0.22 Apr 26, 2019
@seqizz seqizz force-pushed the seqizz:g_pysnooper branch from cffc48b to 0cf8e7e Apr 26, 2019
@seqizz
Copy link
Contributor Author

@seqizz seqizz commented Apr 26, 2019

Re-pushed with suggested changes

Copy link
Member

@dotlambda dotlambda left a comment

The first commit message needs to be amended.

@dotlambda
Copy link
Member

@dotlambda dotlambda commented Apr 26, 2019

@GrahamcOfBorg build python2.pkgs.pysnooper python3.pkgs.pysnooper

@seqizz
Copy link
Contributor Author

@seqizz seqizz commented Apr 26, 2019

Pushed again

@seqizz seqizz force-pushed the seqizz:g_pysnooper branch from 0cf8e7e to 910c94b Apr 26, 2019
@dotlambda
Copy link
Member

@dotlambda dotlambda commented May 2, 2019

@seqizz cool-RR/python_toolbox#3 seems to have been resolved.

@seqizz seqizz force-pushed the seqizz:g_pysnooper branch from 910c94b to c687b36 May 3, 2019
@seqizz
Copy link
Contributor Author

@seqizz seqizz commented May 3, 2019

Switched to fetchFromGitHub to get the latest release. Yet not sure how to test this 😕 I can't see the tests on pysnooper build when I try, since there is no way to say "force rebuild" on nix-shell or nix-build as far as I can find.

@seqizz seqizz force-pushed the seqizz:g_pysnooper branch from c687b36 to 899a3be May 31, 2019
@seqizz seqizz changed the title pythonPackages.pysnooper: init at 0.0.22 pythonPackages.pysnooper: init at 0.1.0 May 31, 2019
@seqizz
Copy link
Contributor Author

@seqizz seqizz commented May 31, 2019

Pushed 0.1.0

@FRidh
Copy link
Member

@FRidh FRidh commented Jul 20, 2019

@GrahamcOfBorg build pythonPackages.pysnooper python3Packages.pysnooper

@seqizz
Copy link
Contributor Author

@seqizz seqizz commented Jul 25, 2019

I think github is confused, suggested change is already done..
I wish I could've helped maintaining the nixos repo more, since I can see the MR/issue pile 😶 But you can see the quality of my commits already 😬

@seqizz seqizz force-pushed the seqizz:g_pysnooper branch from 899a3be to 784ed41 Aug 7, 2019
@seqizz seqizz changed the title pythonPackages.pysnooper: init at 0.1.0 pythonPackages.pysnooper: init at 0.2.4 Aug 7, 2019
@seqizz
Copy link
Contributor Author

@seqizz seqizz commented Aug 7, 2019

After this much time, I guess I know a bit more what I am doing 😃
Upgraded to latest version, also built fine on my box.

@seqizz seqizz force-pushed the seqizz:g_pysnooper branch from 784ed41 to 7bd8758 Oct 6, 2019
@seqizz seqizz changed the title pythonPackages.pysnooper: init at 0.2.4 pythonPackages.pysnooper: init at 0.2.8 Oct 6, 2019
@seqizz seqizz requested a review from dotlambda Nov 14, 2019
@seqizz seqizz force-pushed the seqizz:g_pysnooper branch from 7bd8758 to 0b02c65 Dec 30, 2019
@seqizz seqizz requested a review from jonringer as a code owner Dec 30, 2019
@seqizz seqizz changed the title pythonPackages.pysnooper: init at 0.2.8 pythonPackages.pysnooper: init at 0.3.0 Dec 30, 2019
@seqizz seqizz force-pushed the seqizz:g_pysnooper branch from 0b02c65 to d76c8d9 Dec 31, 2019
@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Jan 3, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/81

Copy link
Contributor

@jonringer jonringer left a comment

diff LGTM
commits LGTM
has tests 👍

failures appear to be upstream issues

[5 built (1 failed), 0.0 MiB DL]
error: build of '/nix/store/c07fmi7g9j9ggfy9jkwcddq53ycny9g0-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/60228
2 package failed to build:
python38Packages.pysnooper python38Packages.python-toolbox

3 package built:
python27Packages.pysnooper python37Packages.pysnooper python37Packages.python-toolbox
@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 3, 2020

@GrahamcOfBorg build python27Packages.pysnooper python37Packages.pysnooper python37Packages.python-toolbox

@jonringer jonringer merged commit 0def56c into NixOS:master Jan 8, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python27Packages.pysnooper, python37Packages.pysnooper, python37Packages.python-toolbox on aarch64-linux Success
Details
python27Packages.pysnooper, python37Packages.pysnooper, python37Packages.python-toolbox on x86_64-darwin Success
Details
python27Packages.pysnooper, python37Packages.pysnooper, python37Packages.python-toolbox on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.