Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memtest86-efi: backport to 19.03 #61806

Merged
merged 3 commits into from Jul 28, 2019

Conversation

@cdepillabout
Copy link
Contributor

commented May 21, 2019

This PR backports the following PRs to 19.03:

  • #60967: memtest86-efi: init at 8.0
  • #61036: nixos/systemd-boot: add support for memtest86 EFI app
  • #60024: libguestfs-with-appliance: Add package for libguesfs containing libguestfs appliances (this is needed for the memtest86-efi derivation)

These PRs do two big things:

  1. Create a memtest86-efi derivation for the newer unfree version of Memtest86 that supports running on UEFI.
  2. Add a NixOS option to install the Memtest86 EFI app so it is available from the systemd-boot menu.
Motivation for this change

The above PRs have all been merged into master. I wanted this functionality available in 19.03 as well.

You can try building the memtest86-efi command with the following, as long as you have this PR checked out:

$ nix-build -A memtest86-efi

You can test installing the memtest86 EFI app with the following nixos setting:

{ config, pkgs, ...}:

{
  boot.loader.systemd-boot.memtest86.enable = true;
}

Although you need to be using systemd-boot for this to work.

Also, you need allowUnfree set to true for both of these to work.

Pinging @c0bw3b and @JohnAZoidberg since they were nice enough to do reviews for the above PRs. Also pinging @Lassulus and @matthewbauer since they merged in the above PRs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse

This comment has been minimized.

Copy link

commented Jun 2, 2019

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/11

@fpletz fpletz added this to the 19.03 milestone Jun 11, 2019

@samueldr

This comment has been minimized.

Copy link
Member

commented Jul 27, 2019

Any reason for 20e0daa not cherry-picking -x ecb90ae?

@samueldr
Copy link
Member

left a comment

Approving, though would be interested in knowing the answer of the question in my (just added) previous comment before merging. Though it looks good enough, and is a useful backport.

The libguestfs backport is non-intrusive, and the memtest86 backport isn't either. In the end a net positive for end-users that may need to test their memory.

roosemberth and others added some commits Apr 22, 2019

Add package for libguesfs containing libguestfs appliances
Appliances are necessary when building images using virt-builder.
(e.g. `virt-builder -o debian-9.img debian-9`)

Signed-off-by: Roosembert Palacios <roosembert.palacios@epfl.ch>
(cherry picked from commit ecb90ae)
memtest86-efi: init at 8.0 (backport to 19.03)
This creates a new package, memtest86-efi.  This is a recent version of
the unfree version of memtest86.

There appear to be no restrictions on the use or redistribution of this.

Backport from #60967.

(cherry picked from commit d273bf5)
(cherry picked from commit e01e13a)
(cherry picked from commit 439a755)
(cherry picked from commit 4abafaf)
nixos/systemd-boot: add support for memtest86 EFI app (backport to 19…
….03)

This commit adds support for installing the memtest86 EFI app and adding
a boot entry for it with systemd-boot.

Backported from #61036.

(cherry picked from commit b12ea62)
(cherry picked from commit d88d675)

@cdepillabout cdepillabout force-pushed the cdepillabout:backport-memtest86 branch from 7718248 to 3c21a29 Jul 28, 2019

@cdepillabout

This comment has been minimized.

Copy link
Contributor Author

commented Jul 28, 2019

@samueldr Thanks for reviewing this.

Any reason for 20e0daa not cherry-picking -x ecb90ae?

No good reason. I probably just forgot to cherry-pick -x it.

I just went back and re-did the commits so that ecb90ae has been cherry-picked. Hopefully it should be good to merge now.

@samueldr samueldr merged commit 16144ba into NixOS:release-19.03 Jul 28, 2019

13 of 15 checks passed

memtest86-efi on aarch64-linux No attempt
Details
memtest86-efi on x86_64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@samueldr

This comment has been minimized.

Copy link
Member

commented Jul 28, 2019

Thank you!

@cdepillabout cdepillabout deleted the cdepillabout:backport-memtest86 branch Jul 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.