-
-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
genymotion: refactor src from requireFile to fetchurl #62109
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for looking into it. I've made a few comments.
@GrahamcOfBorg build genymotion Ah, it's unfree. Scratch that attempt. |
@BadDecisionsAlex Do you want to squash your commits to a single one (which I feel is logical for this change) or should someone who merges this do it for you? :) |
I won’t lie I’ve never done a squash but I’ll do a bit of reading right quick. |
or we can squash from the github UI. |
I think it would be a good idea to learn it then:
|
I really appreciate you taking the time to help me out with this. Thank you! |
The old src url was updated by the host, making the required file inaccessible. The new url links directly to the required file. This direct link allows us to use fetchurl rather than requireFile. genymotion: refactor src url Fixed revisions: 1) Uses `pname`. 2) URL uses version variable in path. Data type for `url` was changed from path to string. genymotion: refactor src url Removed redundant `name` definition. fixed typo in URL changed requireFile to fetchurl
@BadDecisionsAlex Thanks! :) |
The old src url was updated by the host, making the required file inaccessible. The new url links directly to the required file.
Motivation for this change
The old src URL was updated by the host, making the required file inaccessible.
Things done
The old URL was to an html page which shows the most recent version of genymotion.
There was recently a major version update (2.8.0 -> 3.0.2) which now occupies the old URL.
I tried updating our nix expression to the latest package, but ran into issues linking
xcb
.Next I tried finding the old file but could not locate it through genymotion's webpage, or various search engines.
Next I looked at the download URL associated with the newest version. I swapped out the version numbers of the URL, and luckily the file was still available at it's direct path.
I am updating the Nix expression to include this direct path so that it will provide a more helpful message to users.
I am hoping to save future users from the trouble of tracking the file down.
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)