Some cc-wrapper changes to better support darwin and clang #6254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a conditional flag for the c++ std lib - Build binaries that get linked by our own dyld (someday) - Automatically add framework directories in the setup hook
|
cc @shlevy, I can haz hydra? @gridaphobe I didn't want to base it off of #6166 because then my PR's diff view would include all of your stuff as well as mine, and it'd be harder to review. Not sure how best to get the best of both worlds... perhaps a new temporary branch containing both changes to send to hydra? |
|
Let me know when you have a merged branch and I'll make a jobset. |
|
Thanks! |
|
So 29000 packages to build. Does that mean we just take a break for the next couple of weeks? 😄 |
|
Going to merge this into staging, hydra can't handle multiple stdenv rebuilds in parallel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(a new version of #6237 against master)