-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
riemann-tools: 0.2.13 -> 0.2.14, add more config options #62607
Conversation
''; | ||
example = ["myattribute=42"]; | ||
}; | ||
commandSwitches = mkOption { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's some precedence for calling this extraArgs
, so I think we should stick with that.
@@ -34,8 +37,24 @@ in { | |||
Address of the host riemann node. Defaults to localhost. | |||
''; | |||
}; | |||
attributes = mkOption { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this doesn't add a lot of value over commandSwitches
(which I would prefer be called extraArgs
) -- can we scrap it? Keeping NixOS modules small and simple is good for evaluation time and maintainability :)
Added option "extraArgs" to forward any switches to riemann-tools.
Thanks for your advice @srhb |
Updated in #65691. |
@DerTim1 do you mind opening a new PR for that commit please? |
@mmahut Can you cherry pick the commit or do a rebase? Unfortunately I'm busy with other stuff at the moment... |
Motivation for this change
Update riemann-tools (minor version).
Add more NixOS config options (attributes and commandSwitches) to be able to customize the monitoring client.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)